Skip to content

Fix example for mustache in client-side-templates extension.#2409

Merged
alexpetros merged 2 commits intobigskysoftware:masterfrom
airblast-dev:master
Mar 23, 2024
Merged

Fix example for mustache in client-side-templates extension.#2409
alexpetros merged 2 commits intobigskysoftware:masterfrom
airblast-dev:master

Conversation

@airblast-dev
Copy link
Copy Markdown
Contributor

@airblast-dev airblast-dev commented Mar 17, 2024

Description

The unnecessary escape sequences were removed from the mustache full example as they broke the output.
The template key "UserID" was renamed to "UserId" as the test API uses "UserId". The old key name would result in a blank string as the keys wouldnt match.

Corresponding issue:
#2407

Testing

I have tested the changed example in the docs. It is working correctly.

Checklist

  • I have read the contribution guidelines
  • I have targeted this PR against the correct branch (master for website changes, dev for
    source changes)
  • This is either a bugfix, a documentation update, or a new feature that has been explicitly
    approved via an issue
  • I ran the test suite locally (npm run test) and verified that it succeeded

@airblast-dev
Copy link
Copy Markdown
Contributor Author

There is one more thing that should be fixed. The jsbin example linked right under the example in the docs is really out of date, and also uses the incorrect key name "UserID" instead of "UserId". It would be really sweet if the jsbin example could be updated by one of the maintainers with the new example, or just remove the jsbin example altogether.

@Telroshan Telroshan added the documentation Improvements or additions to documentation label Mar 18, 2024
Copy link
Copy Markdown
Collaborator

@alexpetros alexpetros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants