Fix example for mustache in client-side-templates extension.#2409
Merged
alexpetros merged 2 commits intobigskysoftware:masterfrom Mar 23, 2024
Merged
Fix example for mustache in client-side-templates extension.#2409alexpetros merged 2 commits intobigskysoftware:masterfrom
alexpetros merged 2 commits intobigskysoftware:masterfrom
Conversation
Contributor
Author
|
There is one more thing that should be fixed. The jsbin example linked right under the example in the docs is really out of date, and also uses the incorrect key name "UserID" instead of "UserId". It would be really sweet if the jsbin example could be updated by one of the maintainers with the new example, or just remove the jsbin example altogether. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The unnecessary escape sequences were removed from the mustache full example as they broke the output.
The template key "UserID" was renamed to "UserId" as the test API uses "UserId". The old key name would result in a blank string as the keys wouldnt match.
Corresponding issue:
#2407
Testing
I have tested the changed example in the docs. It is working correctly.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded