Returning false to beforeNodeMorphed should affect pantry restore outcome#83
Merged
botandrose merged 2 commits intobigskysoftware:mainfrom Jan 9, 2025
Conversation
botandrose
changed the title
beforeNodeMorphed should affect pantry restore outcomebeforeNodeMorphed should affect pantry restore outcome
botandrose
force-pushed
the
fix-restore-from-pantry-morph-hook
branch
from
31ba94a to
894fb60
Compare
botandrose
changed the title
beforeNodeMorphed should affect pantry restore outcomebeforeNodeMorphed should affect pantry restore outcome
botandrose
changed the title
beforeNodeMorphed should affect pantry restore outcomebeforeNodeMorphed should affect pantry restore outcome
botandrose
force-pushed
the
fix-restore-from-pantry-morph-hook
branch
from
894fb60 to
6c74093
Compare
botandrose
force-pushed
the
fix-restore-from-pantry-morph-hook
branch
from
d0a1374 to
eb796d0
Compare
botandrose
changed the title
beforeNodeMorphed should affect pantry restore outcomebeforeNodeMorphed should affect pantry restore outcome
Collaborator
Author
|
@1cg You mentioned that bugfixes didn't need your approval for merge, so I'm gonna go ahead and merge this one in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The specific motivating use-case is so that Turbo's
data-turbo-permanentwill maintain element contents as expected duringtwoPass, but it seems like the correct thing to do in general.