MAINT: move LikePriorEvaluator to base sampler#1041
Merged
mj-will merged 2 commits intobilby-dev:mainfrom Feb 18, 2026
Merged
Conversation
mj-will
added
the
sampling
Collaborator
|
No objections to this, but what other samplers need this and why? |
Collaborator
|
I'd replace |
adivijaykumar
approved these changes
Feb 12, 2026
This was referenced Feb 13, 2026
mj-will
force-pushed
the
move-sampler-utils
branch
from
944715b to
c294e96
Compare
fgittins
pushed a commit
to fgittins/bilby
that referenced
this pull request
Mar 5, 2026
* MAINT: move LikePriorEvaluator to base sampler * MAINT: improve `LikePriorEvaluator` from `base_sampler`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the
LikePriorEvaluatorclass to base sampler.This allows external sampler plugins to use the class without depending on another sampler plugin. Ideally, I'd get this in for 2.8.0 since it would simplify moving the samplers.
I'm open for suggestions if anyone has thoughts on where to put this.