MAINT: add sampler deprecation warning#822
Merged
mj-will merged 5 commits intobilby-dev:mainfrom Oct 8, 2024
Merged
Conversation
mj-will
added
sampling
This was
linked to
issues
Oct 7, 2024
adivijaykumar
approved these changes
Oct 7, 2024
ColmTalbot
approved these changes
Oct 7, 2024
mj-will
force-pushed
the
add-sampler-deprecation-warning
branch
from
155d2d4 to
7d79ce3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In preparation for removing the nessai and pypolychord interfaces, I've added warnings whenever they are used.
Related to #795 and #774
Original GitLab MR: https://git.ligo.org/lscsoft/bilby/-/merge_requests/1381