Conversation
ColmTalbot
force-pushed
the
analytic-aligned-spin
branch
from
2787d4f to
862797d
Compare
mj-will
reviewed
Nov 14, 2024
mj-will
approved these changes
Feb 4, 2025
mj-will
reviewed
Feb 7, 2025
adivijaykumar
approved these changes
Feb 9, 2025
mj-will
force-pushed
the
analytic-aligned-spin
branch
from
30c2613 to
647c463
Compare
This was referenced Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As pointed out in https://arxiv.org/abs/2305.19907. The numerical method we use for the aligned spin prior breaks down in the extreme high SNR regime. This MR adds an exact version when using the default spin prior.
Copy of https://git.ligo.org/lscsoft/bilby/-/merge_requests/1282