This repository was archived by the owner on Oct 30, 2023. It is now read-only.
Issue 157: Exception when getting all trades of a symbol #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
The issue seems to be when there is content in the response as it contains a field called symbol that the Trade object doesn't have. |
joaopsilva
suggested changes
Jul 20, 2018
Member
joaopsilva
left a comment
joaopsilva
left a comment
There was a problem hiding this comment.
Thanks @pahgo , this looks good. Can you please adjust the indentation of the file?
Author
|
Sure @joaopsilva, I have amended the commit. |
nilswx
pushed a commit
to nilswx/binance-java-api
that referenced
this pull request
Dec 14, 2018
Fixed binance-exchange#157: Add symbol parameter to trades API.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the issue #157 by adding the field in the response to the Trade object.