Skip to content

Registration confirm#32

Merged
micbaumr merged 7 commits into
mainfrom
feat/registration-confirm
Mar 21, 2024
Merged

Registration confirm#32
micbaumr merged 7 commits into
mainfrom
feat/registration-confirm

Conversation

@micbaumr
Copy link
Copy Markdown
Contributor

Description

  • Add toast configuration
  • Fix loader on start on web
  • make button to receive only icon names from icon set, apply styles to icons according on button variant and state
  • add flexGap property to design system
  • add registration confirm

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Screenshot(s)

Please attach some screenshot or a movie if provided changes affects UI.

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • Add correct label to your pull request
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link
Copy Markdown
Contributor

@MateuszRostkowski MateuszRostkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In overall it looks good.

Please add translations or todo comments.

Additionally please check my suggestions about Button component.

Comment on lines +232 to +234
{loading ? (
<Loader type="default" size={24} />
) : (
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previous conditional logic was more readable.

Also you don't need fragment here.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good one! I did it to look more like a previous logic 😄

Comment thread src/screens/ConfirmEmail.tsx Outdated
Comment thread src/screens/ConfirmEmail.tsx Outdated
Comment thread src/screens/ConfirmEmail.tsx Outdated
Comment thread src/screens/ConfirmEmail.tsx Outdated
Comment thread src/screens/ConfirmEmail.tsx Outdated
@micbaumr micbaumr merged commit 7b6a155 into main Mar 21, 2024
@micbaumr micbaumr deleted the feat/registration-confirm branch March 21, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants