Skip to content
This repository was archived by the owner on Feb 22, 2024. It is now read-only.

Amina/77702_personal_details_validation_on_duplicate_account#7266

Merged
matin-deriv merged 18 commits intobinary-com:masterfrom
amina-deriv:personal_details
Mar 6, 2023
Merged

Amina/77702_personal_details_validation_on_duplicate_account#7266
matin-deriv merged 18 commits intobinary-com:masterfrom
amina-deriv:personal_details

Conversation

@amina-deriv
Copy link
Contributor

@amina-deriv amina-deriv commented Oct 7, 2022 •
edited
Loading

Making Personal details and address details form fields immutable if it is immutable from BE

@vercel
Copy link

vercel bot commented Oct 7, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
binary-static ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 6, 2023 at 4:17AM (UTC)

@github-actions
Copy link

github-actions bot commented Oct 7, 2022 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/binary-com/binary-static/pull/7266](https://github.com/binary-com/binary-static/pull/7266)
- **URLs**:
    - **w/ App ID + Server**: https://binary-static-git-fork-amina-deriv-personaldetails.binary.sx/en/logged_inws.html?qa_server=frontend.binaryws.com&app_id=27915
    - **Original**: https://binary-static-git-fork-amina-deriv-personaldetails.binary.sx/en/logged_inws.html
- **App ID**: `27915`

@amina-deriv amina-deriv changed the title personal_details validation Amina/77702_personal_details_validation_on_duplicate_account Oct 7, 2022
@amina-deriv amina-deriv marked this pull request as ready for review October 7, 2022 08:37
prince-deriv
prince-deriv previously approved these changes Oct 7, 2022
View reviewed changes
matin-deriv
matin-deriv previously approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@matin-deriv matin-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amina-deriv amina-deriv dismissed stale reviews from matin-deriv and prince-deriv via 7e8ae69 October 19, 2022 13:30
likhith-deriv
likhith-deriv previously approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@likhith-deriv likhith-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amina-deriv amina-deriv marked this pull request as draft November 9, 2022 11:29
@vercel
Copy link

vercel bot commented Nov 23, 2022

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

@amina-deriv amina-deriv marked this pull request as ready for review November 23, 2022 19:29
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

@matin-deriv matin-deriv merged commit 3de795c into binary-com:master Mar 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.5% 1.5% Duplication

matin-deriv added a commit that referenced this pull request Mar 6, 2023
@matin-deriv
Revert "Amina/77702_personal_details_validation_on_duplicate_account (#…
df959ec 
…7266)"

This reverts commit 3de795c.
@matin-deriv matin-deriv mentioned this pull request Mar 6, 2023
Merged
matin-deriv added a commit that referenced this pull request Mar 6, 2023
@matin-deriv
Revert "Amina/77702_personal_details_validation_on_duplicate_account (#…
bf8f1f3 
…7266)" (#7346)

This reverts commit 3de795c.
matin-deriv added a commit that referenced this pull request Mar 6, 2023
@matin-deriv
Revert "Revert "Amina/77702_personal_details_validation_on_duplicate_…
8c99c91 
…account (#7266)" (#7346)"

This reverts commit bf8f1f3.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

4 more reviewers

@matin-deriv matin-deriv matin-deriv approved these changes

@hubert-deriv hubert-deriv hubert-deriv approved these changes

@likhith-deriv likhith-deriv likhith-deriv approved these changes

@prince-deriv prince-deriv prince-deriv left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@amina-deriv @matin-deriv @hubert-deriv @prince-deriv @likhith-deriv