Mahdiyeh/ remove_cryptocurrency_market#1547
Mahdiyeh/ remove_cryptocurrency_market#1547mustofa-binary merged 3 commits intobinary-com:masterfrom
Conversation
matin-deriv
left a comment
matin-deriv
left a comment
There was a problem hiding this comment.
The reason behind disabling cryptocurrencies is that Crypto only supports Multipliers in contracts_for, it is the same case for Jump indices. Since we don't have Multipliers in platforms other than Deriv-app, we are trying to hide based on the markets, but it is best to filter out based on shortcodes using regex to make sure it will handle other cases and avoid double work in future.
So I suggest using \(?:JD[0-9])|(?:cry_[A-Z])\ to filter out shortcodes. JD for Jump indices and cry for Cryptos.
Feel free to have a look into Zaki's changes in this PR https://redmine.deriv.cloud/issues/30826
matin-deriv
left a comment
matin-deriv
left a comment
There was a problem hiding this comment.
Please help to update the PR
sure, I will work on that |
mahdiyeh-deriv
changed the title
src/navigation/menu.es6
Outdated
| }; | ||
|
|
||
| export const refreshMenu = (root, markets, callback) => { | ||
| const non_crypto = symbol => !/^(cry|JD)/i.test(symbol); |
There was a problem hiding this comment.
Please use a more descriptive name for this function!
3 participants
No description provided.