Adding an option to limit the number of files to be deleted at a single operation #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le operation. The returned Json will only include files deleted. Tests added too.
Owner
|
reviewed your changes, looking good - merged! ... and thanks for that |
Contributor
Author
|
Thanks - BTW - I just noticed that in the README it says that the age is taken from creation date. But in Linux files there is no real creation date, only modification date - and it looks like in your implementation you use mtime (modification time). I think it might be a good idea to update the README. added a pull request for the README. |
Owner
|
well spotted, thanks again man @nirshneor |
binarykitchen
added a commit
that referenced
this pull request
Mar 11, 2018
Adding an option to limit the number of files to be deleted at a single operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returned Json will only include files deleted. Tests added too.
We would like to use this on directories that might have many files - so every time this runs - we would like to limit it's work to # of files.