Skip to content

Avoid backup cache crash#3

Open
tleyden wants to merge 1 commit intobinaryscraping:mainfrom
tleyden:avoid_backup_cache_error
Open

Avoid backup cache crash#3
tleyden wants to merge 1 commit intobinaryscraping:mainfrom
tleyden:avoid_backup_cache_error

Conversation

@tleyden
Copy link
Copy Markdown

@tleyden tleyden commented Feb 8, 2025

Fix for #2

Lmk if this looks good, I still need to clean up formatting (4 space vs 2 space indent)

@david9472
Copy link
Copy Markdown

I had the same issue and implemented a similar fix (see below). Tested your changes -> LGTM

  func backupCache() {
    queue.sync(flags: .barrier) {
      do {
        let encoder = JSONEncoder()
        let dateFormatter = ISO8601DateFormatter()
        dateFormatter.formatOptions = [.withInternetDateTime]

        encoder.dateEncodingStrategy = .custom { date, encoder in
            var container = encoder.singleValueContainer()
            try container.encode(dateFormatter.string(from: date))
        }

        let data = try encoder.encode(cachedLogs)

        try data.write(to: LogsCache.fileURL())
        self.cachedLogs = []
      } catch {
        if isDebug {
          print("Error saving Logs cache.")
        }
      }
    }
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants