Closed
Conversation
maksbotan
reviewed
Apr 21, 2022
| res <- forM variants $ \var -> | ||
| (True <$ validateWithSchemaRef var val) <|> (return False) | ||
| case length $ filter id res of | ||
| (npassing, _nvars) <- countPassingVariants val variants |
Collaborator
There was a problem hiding this comment.
Do you really need to compute second element in the function? Looks like it's not used anywhere 🤔
Author
There was a problem hiding this comment.
right, I was thinking if to use the countPassingVariants also for the allOf case but I couldn't decide :-) I'm open to remove it or to use it
| @@ -0,0 +1,47 @@ | |||
| # This file was autogenerated by Stack. | |||
Collaborator
There was a problem hiding this comment.
Please do not commit this file. This project doesn't really use stack for development, i keep stack.yaml for convenience of contributors, but I do not guarantee it's up to date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We just stumbled on one API endpoint response that has different JSON encodings format depending on a parameter request.
Moreover, those encodings have common cases where the encoding is the same.
I added a new case to the validating function so that
anyOfis supported which is a simpler case ofoneOfwhere any positive number of branches should validate to validate.