🐛 add mandatory permissions for trusted publishing #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelphanth
changed the title
enryH
approved these changes
Aug 14, 2025
Collaborator
enryH
left a comment
enryH
left a comment
There was a problem hiding this comment.
thanks a lot for catching it. I obviously forgot to copy it.... I just moved it to the main settings for the publish rule!
enryH
added a commit
that referenced
this pull request
Sep 18, 2025
* 🎨 add flake8 and ruff line length default (to 90 characters) * 🎨 add formatting of jupyter notebooks per default * 📝 highlight that also a folder has to be renamed * 📝 document what extension are used for * 📝 document debian (ubuntu) package adding which might be needed * 🎨 use PyPI and GitHub integration instead of secret api token * 🙈 hide folders creating when locally building the documentation website * 📝 document desing choices and layout of Python package * 🎨 add copy button for code blocks per default * 🎨 small corrections after proof-reading * 🎨 make name generic and document it. Choose a Licence hint * 🎨 add design document to Sphinx documentation * 🎨 add some more common error checking - set line-length to black default of 88 characters * Apply suggestions from code review * 🐛 correct python pkg configuration file * 🐛 add missing changes for requirments.txt As noted by Angel using requirements.txt needed one additional change: - add dependencies to the dynamic field Add hint to section with dependencies * 📝 Add hint to GitHub Releases and Source distribution testing * 🎨 follow Pasquale's advices (.gitignore + unnecessary config) - add more to .gitignore and link template - remove line-length configuration as it is already on the default 88 of black formatter * 📝 add sebastians hints on other ressources * 🎨 add license key and remove from classifiers as suggested by Sebastian * 📝 docstring and src layout hints (noted by sebastian) * 🐛 add missing key to pyproject.toml --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issue #7