Added hidden file exclusion for MacOS in review and segments #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Can you give me an example of a wrongly picked up file on MacOS? |
Contributor
|
The change will exclude hidden files on MacOS and Linux, i.e.:
|
Contributor
Author
|
I don't have such file right now with me, but the problem occurs when you try to read a folder from the flash drive. I believe it is because of MacOS copying metadata files as described here: https://discussions.apple.com/thread/252896362?sortBy=rank And here: In reality, on a flash drive there will be a bunch of files for example with .wav extensions, but prefixed with . or ._ |
Member
|
Got it, thanks for explaining. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added exclusions in 2 more places, since hidden .wav files on MacOS were picked up.