Skip to content
This repository was archived by the owner on Jan 23, 2024. It is now read-only.

Code style#242

Draft
texhnolyze wants to merge 4 commits intomasterfrom
code_style
Draft

Code style#242
texhnolyze wants to merge 4 commits intomasterfrom
code_style

Conversation

@texhnolyze
Copy link
Contributor

Proposed changes

  • Add black and ruff for Python
  • Add clang-format and cppcheck for C++
  • Add pre-commit configuration and workflow that checks bot

@texhnolyze texhnolyze requested review from Flova and jaagut November 23, 2023 00:55
@texhnolyze texhnolyze marked this pull request as draft November 23, 2023 00:56
by usage of the [pre-commit](https://pre-commit.com/) framework.
We are including the following:
- `ruff` for fast python linting
- `black` for opinionated python auto formatting
- `clang-format` for C++ formatting based on google styles
- `cppcheck` for C++ linting
that will run and check the pre-commit hooks on PRs and updates on the
master branch
with ruff/black for python and cppcheck/clang-format for c++
to prevent full repo autoformatting to affect the git history, when
utilizing `git blame`
@jaagut
Copy link
Member

jaagut commented Nov 23, 2023

Why is this a draft? What's missing?

@jaagut
Copy link
Member

jaagut commented Jan 9, 2024

Ping @texhnolyze

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants