This repository was archived by the owner on Jan 23, 2024. It is now read-only.
Closed
Conversation
Member
|
Why was this closed? At least the HCM changes still make sense imo. |
Member
|
The changes didn't seem to make any improvements. We could merge the new keypoint. But I would prefer to refactor the whole animations, as many parameters are used in many places, which is irritating. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Getting up seemed to work better when adding an extra keyframe.
HCM dsd was changed aswell so that falling on the side will be more similar to standing up from laying on the back.
Related issues
Necessary checks
catkin build