Add support for verifying hashed signatures#7
Merged
bitbeans merged 3 commits intobitbeans:masterfrom Nov 15, 2025
Merged
Conversation
Adding two tests: - verify a legacy signature (as before) - verify a hashed signature To make sure that we remain compatible.
Detect if it's a hashed signature based on the SignatureAlgorithm: - Ed = Ed25519(message) -> legacy - ED = Ed25519(Blake2b-512(message)) -> hashed
LoadMessageFile() is used for signing as well as verifying. By introducing a new method to compute the Blake2b-512 hash, we can get rid of the 1GB size limit for the verifying process.
Collaborator
Author
|
As mentioned in my email, I am willing to continue investing my time and energy into the project. There is still some potential, i.e., creating hashed signatures. As of now, this feature can be considered complete. It would be great if you could review the changes, merge them, and then release them. I have tried to adapt to your coding style as good as possible. If you see improvements, please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces basic support for verifying hashed signatures. This also removes the 1GB limit for verification. The limits are retained for “legacy” hashes.