Trezor: displayaddress#71
Merged
achow101 merged 1 commit intoDec 24, 2018
Merged
Conversation
Member
|
Please rebase onto master now that #66 has been merged. |
Sjors
force-pushed
the
2018/11/trezor-displayaddress
branch
from
473a48a to
4486122
Compare
Member
Author
|
@achow101 rebased |
achow101
reviewed
Dec 17, 2018
Sjors
force-pushed
the
2018/11/trezor-displayaddress
branch
from
4486122 to
30e87de
Compare
Sjors
force-pushed
the
2018/11/trezor-displayaddress
branch
from
30e87de to
1e7ac40
Compare
Member
Author
|
Rebased to support the new Trezor Python driver. Also added tests, though I haven't run those locally and I'm not sure if they would actually catch an error. |
Member
|
tACK 1e7ac40 The test should at least check that the trezor api is being used correctly. |
achow101
added a commit
that referenced
this pull request
Dec 24, 2018
1e7ac40 Trezor: add displayaddress support (Sjors Provoost) Pull request description: Tested with Trezor T for mainnet, testnet using legacy, p2sh-wrapped and native Segwit addressees. Tree-SHA512: 555a5854121971ef222886a09ce23940b0e6102bfa8ecbce31e0bf21631fee5f6446aecdb37ae1bed0663128d993236babc26c0240988a44d49975574e0a3052
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with Trezor T for mainnet, testnet using legacy, p2sh-wrapped and native Segwit addressees.