Skip to content

trezor: add Trezor Safe 5 support#742

Merged
achow101 merged 2 commits into
bitcoin-core:masterfrom
matejcik:matejcik/hwi-ts5
Aug 29, 2024
Merged

trezor: add Trezor Safe 5 support#742
achow101 merged 2 commits into
bitcoin-core:masterfrom
matejcik:matejcik/hwi-ts5

Conversation

@matejcik
Copy link
Copy Markdown
Contributor

@matejcik matejcik commented Jul 1, 2024

just updated definitions from upstream trezorlib

Copy link
Copy Markdown
Collaborator

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI build failures are reported here trezor/trezor-firmware#3988 but the changes look good to me!

@matejcik matejcik force-pushed the matejcik/hwi-ts5 branch from 42ed442 to e114031 Compare July 1, 2024 14:20
@matejcik
Copy link
Copy Markdown
Contributor Author

matejcik commented Jul 1, 2024

let's see if e114031 helps

@prusnak
Copy link
Copy Markdown
Collaborator

prusnak commented Jul 1, 2024

let's see if e114031 helps

It did, nice!

@craigraw
Copy link
Copy Markdown

Tested this successfully with all related functions on Sparrow.

@prusnak
Copy link
Copy Markdown
Collaborator

prusnak commented Aug 26, 2024

@achow101 Hi! Can we have a merge of this PR and then a new release? Lots of third parties are waiting for this

@matejcik
Copy link
Copy Markdown
Contributor Author

heads-up: during today i'll update the PR with a new model. Ideally I'll also try to fit in a "generic unrecognized Trezor" support.

@achow101
Copy link
Copy Markdown
Member

ACK 3f91b35

Did not test, but looks fine.

@achow101 achow101 merged commit fd19fa7 into bitcoin-core:master Aug 29, 2024
@matejcik matejcik deleted the matejcik/hwi-ts5 branch August 30, 2024 14:06
@ghost
Copy link
Copy Markdown

ghost commented Sep 12, 2024

Hey, do we have any update on the potential release of the new HWI version including this change? I think many people would benefit, including me, so we can finally use the new Trezor with Sparrow and other wallets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants