Skip to content

Display complex wallet address via ID#834

Open
scgbckbone wants to merge 1 commit into
bitcoin-core:masterfrom
scgbckbone:display_addr_by_wallet_id
Open

Display complex wallet address via ID#834
scgbckbone wants to merge 1 commit into
bitcoin-core:masterfrom
scgbckbone:display_addr_by_wallet_id

Conversation

@scgbckbone
Copy link
Copy Markdown
Contributor

  • new display_address_by_wallet_id
    • takes unique ID, change or not, and index (unique ID wrt to coldcard is wallet name)
  • allows to show address of complex miniscript locking scripts that HWI cannot parse
  • restrict display_multisig_address to only work for non-EDGE firmware (p2sh cmd was deprecated in 6.4.1X)
  • restrict display_address_by_wallet_id to be EDGE only

Copy link
Copy Markdown
Contributor Author

@scgbckbone scgbckbone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usage:

$ ./hwi.py -f 0f056943 displayaddress --wallet expand_msc
{"address": "tb1qmmvrggqr3gjp0yvxkcpl4lwtuc42u2a6t09lm4fnjht5zj3vkacq2f6lpq"}

$ ./hwi.py -f 0f056943 displayaddress --wallet expand_ms
{"error": "Coldcard Error: Miniscript wallet not found", "code": -7}

$ ./hwi.py -f 0f056943 displayaddress --wallet expand_msc --change 
{"address": "tb1q22pnyefl54pl7y7th4yly3c84d9hmdlqdvl6xcd7zmg9gthedyfqgmrgal"}

$ ./hwi.py -f 0f056943 displayaddress --wallet expand_msc --change --idx 523
{"address": "tb1qtctvjca4mlg2ent3ydjswsqlc4vh2p7j80c67fpvrlfkchzm8dzs8z9dr8"}

$ ./hwi.py -f 0f056943 displayaddress --wallet expand_msc --change --idx 2147483648
{"error": "child idx", "code": -13}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant