Conversation
Member
Author
|
Had to rebase |
Collaborator
|
failing: |
Member
Author
|
Fixed the error |
13ed96f to
f94fe58
Compare
Member
|
Concept ACK. But let's use named arguments, especially for |
Member
Author
|
Do you mean give each argument a default value or do you mean having the call be |
Member
|
The latter. It's probably fine to keep some arguments like |
Moves the command argument parsing to hwi.py. Instead of each function taking args and client, they now take client and whatever else they need. hwi.py handles the conversion from args and client to the actual arguments.
Member
Author
|
@Sjors Done. |
Member
|
Travis unhappy: |
Member
Author
|
Seems like a spurious failure. I restarted the travis build and it seems fine now |
Member
achow101
added a commit
that referenced
this pull request
Jan 21, 2019
8e4b3fc Add executable script to setup.py and bump version number (Andrew Chow) 2ddd4ed Refactor to make hwilib more like a library (Andrew Chow) Pull request description: Refactors `command.py` so that it just has the functions for each command and the arguments are the actual arguments for the command instead of `args` and `client`. `process_commands` has been moved to `cli.py` along with the handlers that take `args` and `client` which then call the functions in `commands.py` to do the command. `setup.py` has been updated to also install a `hwi` executable script and the version number is bumped to 0.0.5. This makes HWI actually usable as a library while also having the command line functionality. Completes part 1 of #91 Tree-SHA512: 73c36f79b3f28140f1600cd263325d2fffc422b759884bccb613f0ca922d76801973a41fbd52cba0b4142f19f97ac465cfe7277748e4511cadc461f16ba3026c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
command.pyso that it just has the functions for each command and the arguments are the actual arguments for the command instead ofargsandclient.process_commandshas been moved tocli.pyalong with the handlers that takeargsandclientwhich then call the functions incommands.pyto do the command.setup.pyhas been updated to also install ahwiexecutable script and the version number is bumped to 0.0.5.This makes HWI actually usable as a library while also having the command line functionality.
Completes part 1 of #91