qml: Follow-up to PR#101#112
Merged
Merged
Conversation
Contributor
shaavan
commented
Jan 13, 2022
shaavan
commented
- This PR is a follow-up to Add and demo ConnectionSettings and ContinueButton components #101 and addresses suggestions of this comment.
- The changes are split into separate commits so that they can be easier to review, and reason with.
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required.
promag
reviewed
Jan 13, 2022
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#112 Rebased-From: fe41329
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#112 Rebased-From: be87ba9
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#112 Rebased-From: a0ba0d7
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required. Github-Pull: bitcoin-core#112 Rebased-From: f5458f2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: fe41329
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: be87ba9
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: a0ba0d7
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required. Github-Pull: bitcoin-core#112 Rebased-From: f5458f2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: fe41329
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: be87ba9
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#112 Rebased-From: a0ba0d7
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required. Github-Pull: bitcoin-core#112 Rebased-From: f5458f2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: fe41329
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: be87ba9
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: a0ba0d7
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required. Github-Pull: bitcoin-core#112 Rebased-From: f5458f2
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: fe41329
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: be87ba9
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#112 Rebased-From: a0ba0d7
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
- Modified property last so that it can automatically be derived by root positioning in parent element. - Made header property to be necessarily required. Github-Pull: bitcoin-core#112 Rebased-From: f5458f2
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
7113e38 qml: Make further suggested changes to Settings.qml (Shashwat) a9d6910 qml: Replace GridLayout with nested Column Row Layout in Settings.qml (Shashwat) ad8d06c qml: Use Math.round() in OptionSwitch.qml (Shashwat) 1cef5ce qml: Using qsTr() with strings in ConnectionSettings.qml (Shashwat) Pull request description: - This PR is a follow-up to #101 and addresses suggestions of [this](bitcoin-core/gui-qml#101 (comment)) comment. - The changes are split into separate commits so that they can be easier to review, and reason with. ACKs for top commit: promag: Code review ACK 7113e38. Tree-SHA512: f1a421a74fcf61a861720f4a9ad489042964f022db186fce6f9d9013af37f6575a2bef11ea02c4b79eeefdd8e89aab4f2bae86a0d30d0e47b889ce4d595781fc
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
7113e389b635b45d1e99ada85795ee5922d9ca62 qml: Make further suggested changes to Settings.qml (Shashwat) a9d6910fbc3a8517ceb3140a0d479338ff65d2ab qml: Replace GridLayout with nested Column Row Layout in Settings.qml (Shashwat) ad8d06cce00b8a75c01c4f1eda89b888f11ad1a5 qml: Use Math.round() in OptionSwitch.qml (Shashwat) 1cef5ce8cc1c04d16dec277a21e13ae11b30631a qml: Using qsTr() with strings in ConnectionSettings.qml (Shashwat) Pull request description: - This PR is a follow-up to #101 and addresses suggestions of [this](bitcoin-core/gui-qml#101 (comment)) comment. - The changes are split into separate commits so that they can be easier to review, and reason with. ACKs for top commit: promag: Code review ACK 7113e389b635b45d1e99ada85795ee5922d9ca62. Tree-SHA512: f1a421a74fcf61a861720f4a9ad489042964f022db186fce6f9d9013af37f6575a2bef11ea02c4b79eeefdd8e89aab4f2bae86a0d30d0e47b889ce4d595781fc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.