qml: Add DropShadow to the OptionSwitch indicatorButton#132
Conversation
jarolrod
left a comment
There was a problem hiding this comment.
CI is failing because you have to allow static builds to pull in these plugins, here's an example on how to accomplish this: https://github.com/bitcoin-core/gui-qml/pull/45/files
|
Could you post screenshots please? Also I'd like to have some Concept ACKs from designers before introducing a new plugin. |
| #if defined(QT_STATICPLUGIN) | ||
| #include <QtPlugin> | ||
| Q_IMPORT_PLUGIN(QtGraphicalEffectsPlugin) | ||
| Q_IMPORT_PLUGIN(QtGraphicalEffectsPrivatePlugin) |
There was a problem hiding this comment.
Why importing of private plugin is required?
|
In the recent Bitcoin Core App Design Call on 06-29-2022, it was discussed the need to introduce a dependency So I shall be closing this PR until later. |
Ported #111 to this PR.
This PR rebase #111 on the current master.
Notes:
Qt version 5.15.3.spread: 0.0 samples: 21 - color: "#00000040" + color: "#7900fffc" source: indicatorButton } }