Make links, data location and numerical description value un-translatable#140
Closed
shaavan wants to merge 1 commit into
Closed
Make links, data location and numerical description value un-translatable#140shaavan wants to merge 1 commit into
shaavan wants to merge 1 commit into
Conversation
Merged
shaavan
changed the title
jarolrod
reviewed
Aug 2, 2022
shaavan
changed the title
shaavan
force-pushed
the
220802-onboarding-views-followup-1
branch
from
940a009 to
7ff6ff2
Compare
jarolrod
reviewed
Aug 13, 2022
Contributor
|
should rebase over changes on master |
shaavan
force-pushed
the
220802-onboarding-views-followup-1
branch
from
7ff6ff2 to
0b689ad
Compare
Contributor
|
should rebase and incorporate with changes done on master since last push |
Collaborator
|
concept ack |
Contributor
|
Picked up in #217 |
Member
Closing this one. |
hebasto
added a commit
that referenced
this pull request
Jan 17, 2023
d528468 qml: Make links, data location and numerical description value un-translatable. (shaavan) Pull request description: This picks up and replaces #140 Rebases and removes one more occurrence of a value qsTr() on an untranslatable value. [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/217) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/217) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/217) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/217) ACKs for top commit: hebasto: ACK d528468 Tree-SHA512: c4db9d020b370d8a33868eda14941f4f29cc687924fbd568991b96f2a8e980da9c7d8f2f14bc872dab09310cf0d0783aa10d04fee1561965b443499304f839cf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #124 and addresses this comment.
This PR removed the
qsTr()tag for the description strings, which were links, disk locations, or numerical values, and hence wouldn't be translated from their source language.