Introducing Reusable Setting Views by jarolrod · Pull Request #197 · bitcoin-core/gui-qml

jarolrod · 2022-12-07T06:00:18Z

This makes the settings views independent from the onboarding views and refactors the definition of the settings views so that these now independent settings view pages can be reused anywhere and as many times as we need to; they are not delegated to only be used within the onboarding wizard.

Desktop

Master

master-1	master-2	master-3	master-4

PR

pr-1	pr-2	pr-3	pr-4

hebasto · 2022-12-08T11:52:47Z

based on #192

#192 has just been merged. Rebase?

johnny9

ACK 3e62f27

Much clearer definition of the Settings pages and much better file naming when looking for a page with specific context. One minor quirk with the naming of the page and the selection component that can be thought about and addressed later if a solution is found.

Views render as expected and no qml warnings when run.

johnny9 · 2022-12-08T15:26:49Z

+    detailActive: true
+    detailItem: ColumnLayout {
+        spacing: 0
+        StorageSettings {


The naming here ends up being a bit funny as its nearly identical to the parent component's name. Maybe append to the component name something that signifies that it is just the selection piece or use "import as" when bringing in the component.

Just noticed the naming here are the same words in reversed order :D, can anyone suggest better naming here?

@GBKS: SettingsStorage.qml represents the actualy page view for the Settings that are related to Storage. And StorageSettings is a component we place inside of SettingsStorage.qml that represents the table of advanced settings which are related to Storage.

since this component is already under a "settings" folder. Maybe StorageSettingsPage is better name for the component and then something equivalent for the other components since it is a "Page" that holds the "StorageSettings"

johnny9 · 2022-12-08T15:35:59Z

-        Loader {
-            source:"onboarding01a.qml"
+        InformationPage {
+            Layout.fillWidth: true


SwipeViews don't handle Layout properties. Think this can be removed.

thanks for spotting these, it's a bad habit of mine to place this until the view is working correctly. Since you've already opened a PR to address them, i've left this as is.

johnny9

Noticed some Layout properties that likely are unused. Might be best to address in a separate PR.

Edit: Starting PR #201

johnny9 · 2022-12-08T16:09:41Z

-    background: null
-    clip: true
+InformationPage {
    Layout.fillWidth: true


This Layout property can be removed

johnny9 · 2022-12-08T16:09:53Z

-    background: null
-    clip: true
+InformationPage {
    Layout.fillWidth: true


johnny9 · 2022-12-08T16:10:05Z

-Page {
-    background: null
+InformationPage {
    Layout.fillWidth: true


johnny9 · 2022-12-08T16:10:16Z

-        Loader {
-            source:"onboarding05a.qml"
+        InformationPage {
+            Layout.fillWidth: true


johnny9 · 2022-12-08T16:10:33Z

-        Loader {
-            source:"onboarding06a.qml"
+        InformationPage {
+            Layout.fillWidth: true


johnny9 · 2022-12-08T16:11:55Z

+import "../../components"
+
+InformationPage {
+    Layout.fillWidth: true


johnny9 · 2022-12-08T16:12:05Z

+
+InformationPage {
+    background: null
+    Layout.fillWidth: true


johnny9 · 2022-12-08T16:12:14Z

+import "../../components"
+
+InformationPage {
+    Layout.fillWidth: true


johnny9 · 2022-12-08T16:12:23Z

+import "../../components"
+
+InformationPage {
+    Layout.fillWidth: true


This extracts out the navbar element defintions from the settings page itself, and moves it to where the page is instantiated. This allows the settings views to be reused anywhere else we want to use them, and are now no longer limited to being used within the onboarding wizard.

jarolrod · 2022-12-08T17:18:12Z

Updated from 3e62f27 to 30db8cc

changes: rebased over master

hebasto

ACK 30db8cc, I have reviewed the code and it looks OK, I agree it can be merged.

Github-Pull: bitcoin-core#197 Rebased-From: 5f11241

Github-Pull: bitcoin-core#197 Rebased-From: 86170be

This extracts out the navbar element defintions from the settings page itself, and moves it to where the page is instantiated. This allows the settings views to be reused anywhere else we want to use them, and are now no longer limited to being used within the onboarding wizard. Github-Pull: bitcoin-core#197 Rebased-From: 30db8cc

Github-Pull: bitcoin-core#197 Rebased-From: 5f11241

Github-Pull: bitcoin-core#197 Rebased-From: 86170be

This extracts out the navbar element defintions from the settings page itself, and moves it to where the page is instantiated. This allows the settings views to be reused anywhere else we want to use them, and are now no longer limited to being used within the onboarding wizard. Github-Pull: bitcoin-core#197 Rebased-From: 30db8cc

Github-Pull: bitcoin-core#197 Rebased-From: 5f11241

Github-Pull: bitcoin-core#197 Rebased-From: 86170be

This extracts out the navbar element defintions from the settings page itself, and moves it to where the page is instantiated. This allows the settings views to be reused anywhere else we want to use them, and are now no longer limited to being used within the onboarding wizard. Github-Pull: bitcoin-core#197 Rebased-From: 30db8cc

This was referenced Dec 7, 2022

Do not dynamically load OnboardingViews from url, which now have descriptive names #198

Merged

Better TextButton control default values #199

Merged

mouxdesign mentioned this pull request Dec 8, 2022

Documenting the process BitcoinDesign/Bitcoin-Core-App#24

Open

johnny9 approved these changes Dec 8, 2022

View reviewed changes

johnny9 reviewed Dec 8, 2022

View reviewed changes

johnny9 mentioned this pull request Dec 8, 2022

Remove extra layout properties #201

Merged

jarolrod added 3 commits December 8, 2022 12:09

qml: make settings pages independent from onboarding pages

5f11241

qml: do not load settings pages from url inside of onboarding pages

86170be

jarolrod force-pushed the extract-settings-pages branch from 3e62f27 to 30db8cc Compare December 8, 2022 17:15

hebasto approved these changes Dec 9, 2022

View reviewed changes

hebasto merged commit c071463 into bitcoin-core:main Dec 9, 2022

hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025

qml: make settings pages independent from onboarding pages

b5580fd

Github-Pull: bitcoin-core#197 Rebased-From: 5f11241

hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 8, 2025

qml: do not load settings pages from url inside of onboarding pages

8ace10b

Github-Pull: bitcoin-core#197 Rebased-From: 86170be

hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025

qml: make settings pages independent from onboarding pages

f1e3fa8

Github-Pull: bitcoin-core#197 Rebased-From: 5f11241

hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025

qml: do not load settings pages from url inside of onboarding pages

0b27ee5

Github-Pull: bitcoin-core#197 Rebased-From: 86170be

hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025

qml: make settings pages independent from onboarding pages

add17b5

Github-Pull: bitcoin-core#197 Rebased-From: 5f11241

hebasto pushed a commit to hebasto/gui-qml that referenced this pull request Jun 9, 2025

qml: do not load settings pages from url inside of onboarding pages

6a5be76

Github-Pull: bitcoin-core#197 Rebased-From: 86170be

Conversation

jarolrod commented Dec 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Desktop

Master

PR

Uh oh!

hebasto commented Dec 8, 2022

Uh oh!

johnny9 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnny9 Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnny9 Dec 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnny9 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jarolrod commented Dec 8, 2022

Uh oh!

hebasto left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jarolrod commented Dec 7, 2022 •

edited

Loading

johnny9 Dec 8, 2022 •

edited

Loading

johnny9 Dec 8, 2022 •

edited

Loading

johnny9 left a comment •

edited

Loading