Introduce check icon#204
Merged
Merged
Conversation
This was referenced Dec 14, 2022
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#204 Rebased-From: 76287e4
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#204 Rebased-From: 76287e4
hebasto
pushed a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#204 Rebased-From: 76287e4
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
ee18b22 qml: introduce check icon (Jarol Rodriguez) Pull request description: Introduces the `check` icon from the Bitcoin Icons set. The svg is taken from optimized/filled and the png has been ran through the optimization script. The current production use-case of this icon will be for the [check icon](https://www.figma.com/file/GaCoOSNHB2yMB9ThiDtred/Bitcoin-Core-App?node-id=5733%3A139691&t=9577jMhj1i9bCaJi-0) that is part of the current design for the OptionButton control. The [check icon](https://github.com/BitcoinDesign/Bitcoin-Icons/blob/main/optimized/filled/bitcoin-check.svg) was taken from the [Bitcoin-Icons Repo](https://github.com/BitcoinDesign/Bitcoin-Icons). This was used to generate a PNG of 128x128 size using inkscape. The resulting PNG was then run through the [optimize-pngs.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimize-pngs.py) script. The output of the script is as follows: ``` optimizing check.png... done summary: +++++++++++++++++ check.png size diff from: 1291 to: 829 old sha256: 4436036d05b03fb55ad86e684beb125aa4805b78c4b4d276e5a372ffe5ef2941 new sha256: c8f95de9fa3c98fa318f0eaa55e658f61d6a19e78761b2ccd774f9f9ba6d8ee4 completed. Checksum stable: False. Total reduction: 462 bytes ``` You can demo this by testing bitcoin-core/gui-qml#205 [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/204) ACKs for top commit: johnny9: ACK ee18b22 Tree-SHA512: 37bdc1153774226f6ca53694c8098a3f6eba3a9ef157ce49db1da7afdb87b2d9b6afbb82c45e8f269d91fc9c56747bba8d6854c3001b52e8115aeceaff4106c5
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
ee18b22f51444fcc69517b0ae7bc232e85dce1db qml: introduce check icon (Jarol Rodriguez) Pull request description: Introduces the `check` icon from the Bitcoin Icons set. The svg is taken from optimized/filled and the png has been ran through the optimization script. The current production use-case of this icon will be for the [check icon](https://www.figma.com/file/GaCoOSNHB2yMB9ThiDtred/Bitcoin-Core-App?node-id=5733%3A139691&t=9577jMhj1i9bCaJi-0) that is part of the current design for the OptionButton control. The [check icon](https://github.com/BitcoinDesign/Bitcoin-Icons/blob/main/optimized/filled/bitcoin-check.svg) was taken from the [Bitcoin-Icons Repo](https://github.com/BitcoinDesign/Bitcoin-Icons). This was used to generate a PNG of 128x128 size using inkscape. The resulting PNG was then run through the [optimize-pngs.py](https://github.com/bitcoin-core/bitcoin-maintainer-tools/blob/master/optimize-pngs.py) script. The output of the script is as follows: ``` optimizing check.png... done summary: +++++++++++++++++ check.png size diff from: 1291 to: 829 old sha256: 4436036d05b03fb55ad86e684beb125aa4805b78c4b4d276e5a372ffe5ef2941 new sha256: c8f95de9fa3c98fa318f0eaa55e658f61d6a19e78761b2ccd774f9f9ba6d8ee4 completed. Checksum stable: False. Total reduction: 462 bytes ``` You can demo this by testing bitcoin-core/gui-qml#205 [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/204) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/204) ACKs for top commit: johnny9: ACK ee18b22f51444fcc69517b0ae7bc232e85dce1db Tree-SHA512: 37bdc1153774226f6ca53694c8098a3f6eba3a9ef157ce49db1da7afdb87b2d9b6afbb82c45e8f269d91fc9c56747bba8d6854c3001b52e8115aeceaff4106c5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the
checkicon from the Bitcoin Icons set. The svg is taken from optimized/filled and the png has been ran through the optimization script.The current production use-case of this icon will be for the check icon that is part of the current design for the OptionButton control.
The check icon was taken from the Bitcoin-Icons Repo. This was used to generate a PNG of 128x128 size using inkscape. The resulting PNG was then run through the optimize-pngs.py script. The output of the script is as follows:
You can demo this by testing #205