Remove extra ColumnLayouts

[johnny9]

Follow up to #203

[johnny9]

This is required due to an oddity with the StackView initial state. It will be ignored with the anchor properties.

[jarolrod]

there's an intricate issue with this where this will start off fine being a maximum of 450 px width, but if you resize the window to be a smaller width, then resize to be larger, the width of the storage location OptionButtons will become larger than 450px. I assume this would be rare to run into, but the code has an issue (albeit rare) that isn't present with the code on master:

OnboardingStorageAmount.qml is immune to this because it keeps the nested ColumnLayout method since it is actually appropriate there.

[johnny9]

Yeah i need to rework this. I was thinking about these pieces wrong. There is a conflict with the InformationPage column widths.

[jarolrod]

this issue is fixed now as of f9f46e7, thanks!

[johnny9]

Update from 0e2e651 to f9f46e7

• Potential maximum width solution for issue @jarolrod pointed out

[jarolrod]

the top margin for the columnlayout here doesn't seem to draw the same, PR on left, master on right:

Also in general, it appears that the left and right margins are different throughout the views now, but will confirm on macos.

[jarolrod]

And the PR NodeSettings isn't max 450 here

[johnny9]

Great catch. I now see Page has its own padding property and is ignoring my anchor values. https://doc.qt.io/qt-6/qml-qtquick-controls2-control.html#padding-prop.

[johnny9]

those padding values apply to just the "contentItem" for Pages

[johnny9]

Ill go through a side-by-side with master as well, just need to setup a second view to compile from

[johnny9]

Update from f9f46e7 to 4dc32c4:

• Fix NodeSettings padding/margins by setting the Page padding values instead of using anchors.

[johnny9]

Master (left) / PR (right)

[jarolrod]

tACK 4dc32c4

Changes are good and there is no visual difference between master and pr. Tested on macOS and Linux desktop as well as Android on a phone and tablet.