Skip to content

Introduce the Peers page#259

Merged
hebasto merged 2 commits into
bitcoin-core:mainfrom
johnny9:peers
Feb 17, 2023
Merged

Introduce the Peers page#259
hebasto merged 2 commits into
bitcoin-core:mainfrom
johnny9:peers

Conversation

@johnny9
Copy link
Copy Markdown
Collaborator

@johnny9 johnny9 commented Feb 13, 2023

Adds a new page under Node settings that shows a list of connected peers. A ProxyModel is added to translate the original PeerTableModel into a model that the ListView can handle.

Windows
Intel macOS
Apple Silicon macOS
ARM64 Android

Screenshot from 2023-02-12 22-38-10
Screenshot from 2023-02-12 22-38-30

@johnny9 johnny9 force-pushed the peers branch 5 times, most recently from d820174 to d0c72f8 Compare February 13, 2023 04:07
@johnny9
Copy link
Copy Markdown
Collaborator Author

johnny9 commented Feb 13, 2023

Update from d820174 to d0c72f8:

  • fix whitespace lint errors

@hebasto hebasto changed the title qml: Introduce the Peers page Introduce the Peers page Feb 13, 2023
@jarolrod jarolrod mentioned this pull request Feb 15, 2023
@johnny9
Copy link
Copy Markdown
Collaborator Author

johnny9 commented Feb 16, 2023

Update from d0c72f8 to 46615f:

  • Rebased with main
  • Used the Separator component in the ListView layout
  • Included a footer that shows the PeersIndicator as well as text describing the how many more peers until max

Screenshot from 2023-02-15 20-01-52

Copy link
Copy Markdown
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking perfect, just missed one thing

Comment thread src/qml/pages/node/NodeSettings.qml
@johnny9
Copy link
Copy Markdown
Collaborator Author

johnny9 commented Feb 16, 2023

Update from 46615ff to c9aaeae:

  • squashed Separator changes into the original commit
  • Included separator in NodeSettings Peers link
  • Used CaretRightButton in NodeSettings Peers link

Copy link
Copy Markdown
Contributor

@jarolrod jarolrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK c9aaeae

tested on macOS, linux, and Android

@hebasto hebasto merged commit b29d499 into bitcoin-core:main Feb 17, 2023
johnny9 pushed a commit to johnny9/bitcoin-core-app that referenced this pull request Jul 4, 2025
b9fa9be qml: add Looking for peers footer to Peers (johnny9)
662e5b8 qml: Introduce the Peers page (johnny9)

Pull request description:

  Adds a new page under Node settings that shows a list of connected peers.  A ProxyModel is added to translate the original PeerTableModel into a model that the ListView can handle.

  [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/259)
  [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/259)
  [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/259)
  [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/259)

  ![Screenshot from 2023-02-12 22-38-10](https://user-images.githubusercontent.com/985648/218367663-54a31931-cd25-49b6-80b6-2b17a99edd76.png)
  ![Screenshot from 2023-02-12 22-38-30](https://user-images.githubusercontent.com/985648/218367593-f8b693d7-0f37-48f7-a7f0-996566697a9d.png)

ACKs for top commit:
  jarolrod:
    ACK b9fa9be

Tree-SHA512: 127a36da2428b8bc1bac23d02c7d5be775f5475355b044a1ec4a86b3ab077e76f611c3a9a8d9b0cd533e8adca2441fd84b6ec0d38be31f0f7380d17c5f3c7a70
tx-signer450 added a commit to tx-signer450/gui-qml that referenced this pull request Oct 20, 2025
b9fa9bec0e1910071251ececa8d6df07c57320c3 qml: add Looking for peers footer to Peers (johnny9)
662e5b87918bc4243bcf312fb0e60ef5ef53526d qml: Introduce the Peers page (johnny9)

Pull request description:

  Adds a new page under Node settings that shows a list of connected peers.  A ProxyModel is added to translate the original PeerTableModel into a model that the ListView can handle.

  [![Windows](https://img.shields.io/badge/OS-Windows-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/259)
  [![Intel macOS](https://img.shields.io/badge/OS-Intel%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/259)
  [![Apple Silicon macOS](https://img.shields.io/badge/OS-Apple%20Silicon%20macOS-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip?branch=pull/259)
  [![ARM64 Android](https://img.shields.io/badge/OS-Android-green)](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/259)

  ![Screenshot from 2023-02-12 22-38-10](https://user-images.githubusercontent.com/985648/218367663-54a31931-cd25-49b6-80b6-2b17a99edd76.png)
  ![Screenshot from 2023-02-12 22-38-30](https://user-images.githubusercontent.com/985648/218367593-f8b693d7-0f37-48f7-a7f0-996566697a9d.png)

ACKs for top commit:
  jarolrod:
    ACK b9fa9bec0e1910071251ececa8d6df07c57320c3

Tree-SHA512: 127a36da2428b8bc1bac23d02c7d5be775f5475355b044a1ec4a86b3ab077e76f611c3a9a8d9b0cd533e8adca2441fd84b6ec0d38be31f0f7380d17c5f3c7a70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants