Handle pre & headers sync states, add header verification to Block Clock verification progress#277
Closed
jarolrod wants to merge 2 commits into
Closed
Handle pre & headers sync states, add header verification to Block Clock verification progress#277jarolrod wants to merge 2 commits into
jarolrod wants to merge 2 commits into
Conversation
ea58e24 to
6bfccd9
Compare
Contributor
Author
|
Updated from ea58e24 to 6bfccd9, compare Changes:
|
Collaborator
|
Concept ACK |
johnny9
reviewed
Mar 2, 2023
Collaborator
johnny9
left a comment
There was a problem hiding this comment.
Will need a rebase with the previous PR but the update to synced is great and I don't see the issue with the BlockClock going into the wrong state anymore.
Contributor
Author
|
need to rework, the call to isInIBD makes the UI lock up |
This connects us to the header tip signal so that we can handle when the node is in pre & or headers sync. This calculates the progress of the pre or headers sync and adds it to our verification progress. Pre and headers sync take up 1% of verification progress each, then IBD begins at 2% progress as displayed on the block clock.
This changes when we consider to be synced within the block clock's perspective from a check on if verificationProgress is large enough to a query on the node to see if it is in ibd or not
6bfccd9 to
f6bb1b1
Compare
Contributor
Author
|
rebased over main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This connects us to the header tip signal so that we can handle when the node is in pre & or headers sync. This calculates the progress of the pre or headers sync and adds it to our verification progress. Pre and headers sync take up 1% of verification progress each, then IBD begins at 2% progress as displayed on the block clock.