Add missing topMargin to Navigation Bar middle detail#334
Merged
Conversation
johnny9
approved these changes
May 27, 2023
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
…ar middle detail eca46cb qml: add missing topMargin to Navigation Bar middle detail (jarolrod) Pull request description: This was missed in bitcoin-core/gui-qml#264 | master | pr | | ------ | -- | | <img width="642" alt="Screen Shot 2023-05-26 at 4 03 33 PM" src="https://github.com/bitcoin-core/gui-qml/assets/23396902/fc1523fd-0742-4beb-abb4-850f72a80fe3"> | <img width="642" alt="Screen Shot 2023-05-26 at 3 57 54 PM" src="https://github.com/bitcoin-core/gui-qml/assets/23396902/d643d02e-4410-4267-9521-5405039b0f53"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/334) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/334) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/334) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/334) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android32/unsecure_android_32bit_apk.zip?branch=pull/334) ACKs for top commit: johnny9: ACK eca46cb Tree-SHA512: 9d94d0e031160b6dc33cf4f27d79880dfda6482527146ea129ed98460d91b2177b87404d2ac59e4ac728531444f244abd3e38b049a8ab3106db45bf8f7fbebdd
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
…ar middle detail eca46cbea63ab68ae7c8bcd962fe9e10d738e5fd qml: add missing topMargin to Navigation Bar middle detail (jarolrod) Pull request description: This was missed in bitcoin-core/gui-qml#264 | master | pr | | ------ | -- | | <img width="642" alt="Screen Shot 2023-05-26 at 4 03 33 PM" src="https://github.com/bitcoin-core/gui-qml/assets/23396902/fc1523fd-0742-4beb-abb4-850f72a80fe3"> | <img width="642" alt="Screen Shot 2023-05-26 at 3 57 54 PM" src="https://github.com/bitcoin-core/gui-qml/assets/23396902/d643d02e-4410-4267-9521-5405039b0f53"> | [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip?branch=pull/334) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip?branch=pull/334) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip?branch=pull/334) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip?branch=pull/334) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android32/unsecure_android_32bit_apk.zip?branch=pull/334) ACKs for top commit: johnny9: ACK eca46cbea63ab68ae7c8bcd962fe9e10d738e5fd Tree-SHA512: 9d94d0e031160b6dc33cf4f27d79880dfda6482527146ea129ed98460d91b2177b87404d2ac59e4ac728531444f244abd3e38b049a8ab3106db45bf8f7fbebdd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was missed in #264