Add copyright headers to QML files#34
Merged
Merged
Conversation
-BEGIN VERIFY SCRIPT- git ls-files ./src/qml/pages | xargs -I % ./contrib/devtools/copyright_header.py insert % -END VERIFY SCRIPT-
jarolrod
reviewed
Aug 30, 2021
Contributor
jarolrod
left a comment
jarolrod
left a comment
There was a problem hiding this comment.
ACK f82209d
-
- crACK: Going by bitcoin/bitcoin@071f2fc and extrapolating the relevant lines, the implementation here is sufficient for adding copyright headers to qml files.
-
- tACK: I made a new branch and dropped this commit. I then ran the script provided and got a zero-diff with this commit.
hebasto
added a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 6, 2025
Github-Pull: bitcoin-core#34 Rebased-From: f82209d
hebasto
added a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#34 Rebased-From: f82209d
hebasto
added a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 7, 2025
Github-Pull: bitcoin-core#34 Rebased-From: f82209d
hebasto
added a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 8, 2025
Github-Pull: bitcoin-core#34 Rebased-From: f82209d
hebasto
added a commit
to hebasto/gui-qml
that referenced
this pull request
Jun 9, 2025
Github-Pull: bitcoin-core#34 Rebased-From: f82209d
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
a8c6bf2 scripted-diff: Add copyright headers to QML files (Hennadii Stepanov) f7d3e75b1f50581af580cc3000e7dfb442b1d96e script: Make copyright_header.py script handle QML files (Hennadii Stepanov) Pull request description: This PR: - updates the `copyright_header.py` script to make it handle QML files - adds copyright headers to QML files ACKs for top commit: jarolrod: ACK a8c6bf2 Tree-SHA512: 051acf344d3a7dea2957266d69281b8eb5cc90d07f6c106ee7a391d22463e530539c01f4b66aca4435077002e214fd620205313390b595ebe95e3ca9016b5c24
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
a8c6bf20319f77192f6f2155097651cb1ae2713e scripted-diff: Add copyright headers to QML files (Hennadii Stepanov)
f7d3e75b1f50581af580cc3000e7dfb442b1d96e script: Make copyright_header.py script handle QML files (Hennadii Stepanov)
Pull request description:
This PR:
- updates the `copyright_header.py` script to make it handle QML files
- adds copyright headers to QML files
ACKs for top commit:
jarolrod:
ACK a8c6bf20319f77192f6f2155097651cb1ae2713e
Tree-SHA512: 051acf344d3a7dea2957266d69281b8eb5cc90d07f6c106ee7a391d22463e530539c01f4b66aca4435077002e214fd620205313390b595ebe95e3ca9016b5c24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
copyright_header.pyscript to make it handle QML files