Correct Default Proxy header description on ProxySettings - Follow-up #391#395
Merged
hebasto merged 1 commit intoApr 10, 2024
Conversation
Contributor
Author
|
Gentle reminder to #391's reviewers: @johnny9, @GBKS, @D33r-Gee, @MarnixCroes, @stackingsaunter. |
MarnixCroes
approved these changes
Apr 8, 2024
Contributor
MarnixCroes
left a comment
MarnixCroes
left a comment
There was a problem hiding this comment.
lgtm
maybe Tor Proxy description could be changed also, to
Run Tor connections through a dedicated proxy. to be consistent in the wording and the enable to is a bit redundant as well
Follow-up from bitcoin-core#391 (comment). Removing redundant Tor Proxy description from the top Default Proxy header label. Rewording Tor Proxy description to be consistent with the top header label.
pablomartin4btc
force-pushed
the
qml-ipaddressvalueinput-followup
branch
from
3495832 to
d558b05
Compare
Contributor
Author
|
Updates:
|
Contributor
|
tACK d558b05 |
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
…ion on ProxySettings - Follow-up #391 edbe749 qml, component: Fix labelling on ProxySettings (pablomartin4btc) Pull request description: This is a follow-up from bitcoin-core/gui-qml#391 (comment). <details> <summary>Currently/ <code>main</code> branch screenshot.</summary>  </details> <details> <summary> This PR branch screenshot.</summary>  </details> ACKs for top commit: GBKS: tACK edbe749 D33r-Gee: tACK edbe749 Tree-SHA512: b849bf2addafeac85e645281be162cf22d2f34da613f3da3fcef42377546a33e1b19beacb66660e06bc2e55b6b3c10bae08cf0ecdafb1e470fb8d44b040b6ff0
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
…ion on ProxySettings - Follow-up #391 edbe749856611f82dc0c535f102562dcde58e877 qml, component: Fix labelling on ProxySettings (pablomartin4btc) Pull request description: This is a follow-up from bitcoin-core/gui-qml#391 (comment). <details> <summary>Currently/ <code>main</code> branch screenshot.</summary>  </details> <details> <summary> This PR branch screenshot.</summary>  </details> ACKs for top commit: GBKS: tACK edbe749 D33r-Gee: tACK edbe749856611f82dc0c535f102562dcde58e877 Tree-SHA512: b849bf2addafeac85e645281be162cf22d2f34da613f3da3fcef42377546a33e1b19beacb66660e06bc2e55b6b3c10bae08cf0ecdafb1e470fb8d44b040b6ff0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #391 (comment).
Currently/
mainbranch screenshot.This PR branch screenshot.