Bugfix custom datadir doubleClick - Follow-up #392#399
Conversation
MarnixCroes
left a comment
MarnixCroes
left a comment
There was a problem hiding this comment.
thanks for picking this up.
it doesn't fully fix the problem.
I can still repro sometimes, like +- 1 out of 10 times.
(double-checked I'm not making an error, like accidentally having the second click change the focus.)
Ok, thanks for testing it promptly. I couldn't reproduce the issue on Ubuntu, are you on Mac? If we can't fully fix it, I'd need to investigate another approach and close this one. |
no, Ubuntu 22.04.4 LTS |
|
@MarnixCroes perhaps it has to do with the OS double click (speed?) config, could you please try changing timer interval from 50 to 150 or 300? Thanks! |
I could repro with |
Thanks for testing it again, let's discuss it tomorrow with the rest of the team on the devs call, so far we can have this as a workaround to solve this bug until we find a better approach. |
|
Updates:
|
|
Updates:
|
pablomartin4btc
force-pushed
the
qml-fix-custom-datadir-doubleclick
branch
from
be402aa to
6fca787
Compare
|
Rebased to refresh CIs (#402). No code changes. |
|
Please rebase to resolve conflicts. |
pablomartin4btc
force-pushed
the
qml-fix-custom-datadir-doubleclick
branch
2 times, most recently
from
6fca787 to
5d29207
Compare
|
Rebased as requested. No code changes. |
This is a desktop-only (not mobile) workaround to disable doubleclick on custom datadir which is on the StorageLocations.qml componennt. Double-clicking was causing the file dialog to get open but losing focus and moving to the background, bringing upfront the main window which was useless because the file dialog is modal.
pablomartin4btc
force-pushed
the
qml-fix-custom-datadir-doubleclick
branch
from
5d29207 to
a943329
Compare
|
Updates:
|
| if (AppMode.isDesktop) { | ||
| if (!singleClickTimer.running) { | ||
| // Start the timer if it's not already running | ||
| singleClickTimer.start(); |
There was a problem hiding this comment.
I'm concept NACK on using a timer here
4 participants
This is a desktop-only (not mobile/ android) workaround to disable double-click on custom datadir which is on the
StorageLocations.qmlcomponennt.Double-clicking was causing the file dialog to get open but losing focus and moving to the background, bringing upfront the main window which was useless because the file dialog is modal (issue raised originally by @MarnixCroes on PR #392 but still persists in ongoing PR #397).