Implement createSingleSigWallet#444
Merged
Merged
Conversation
hebasto
changed the title
johnny9
pushed a commit
to johnny9/bitcoin-core-app
that referenced
this pull request
Jul 4, 2025
67007e4 qml: Implement createSingleSigWallet (David Gumberg) Pull request description: Although imperfect, this PR enables completion of the wallet creation flow by implementing `createSingleSigWallet`. Useful for testing #418. ACKs for top commit: johnny9: tACK 67007e4 Tree-SHA512: 0793629688bca179641102d5c390779bc156d174dd1deb6a902fd8a3c908b9ce626fb56d418d31b0048bf093c6ecc4647c92f5e078e2656a4a48c7fc7f0eec2d
tx-signer450
added a commit
to tx-signer450/gui-qml
that referenced
this pull request
Oct 20, 2025
67007e4a812b4e3719434bbb18e68e2cebbd00a0 qml: Implement createSingleSigWallet (David Gumberg)
Pull request description:
Although imperfect, this PR enables completion of the wallet creation flow by implementing `createSingleSigWallet`. Useful for testing #418.
ACKs for top commit:
johnny9:
tACK 67007e4a812b4e3719434bbb18e68e2cebbd00a0
Tree-SHA512: 0793629688bca179641102d5c390779bc156d174dd1deb6a902fd8a3c908b9ce626fb56d418d31b0048bf093c6ecc4647c92f5e078e2656a4a48c7fc7f0eec2d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although imperfect, this PR enables completion of the wallet creation flow by implementing
createSingleSigWallet. Useful for testing #418.