Fixed width for BlockCounter#46
Closed
katesalazar wants to merge 2 commits into
Closed
Conversation
Without this, BlockCounter is continuously changing width unnecessarily. With a fixed width BlockCounter, visual output doesn't change more than strictly necessary. At current window min size, this width fits up to 9 digits, which is enough to fit all of main, test and signature networks. You can spot the difference these changes add by creating two dummy data directories and bootstrapping one with this change and bootstrapping the other one without this change.
This comment was marked as off-topic.
This comment was marked as off-topic.
Prevent BlockCounter label from spilling out of BlockCounter inner "black" content. This change was written on a laptop using a 1280x776 configuration (as reported by `xrandr`). To see this change in and out of action, it might be necessary not to simply rebuild, but also explicitly removing src/qml/qrc_bitcoin.cpp and/or src/qt/qrc_bitcoin.cpp.
promag
reviewed
Oct 3, 2021
Member
Yes. From #31 (comment):
|
Member
|
If you are interested in QML app, you could also look into https://github.com/BitcoinDesign/Bitcoin-Core-App |
Member
|
Going to close this for now. Hope to see more of your contributions into this repo :) |
This comment was marked as off-topic.
This comment was marked as off-topic.
jarolrod
pushed a commit
to jarolrod/gui-qml
that referenced
this pull request
Oct 27, 2021
a44caf65fe Merge bitcoin-core/univalue-subtree#28: Import fixes for sanitizer reported issues 135254331e Import fixes for sanitizer reported issues d5fb86940e refactor: use c++11 range based for loop in checkObject ff9c379304 refactor: Use nullptr (c++11) instead of NULL 08a99754d5 build: use ax_cxx_compile_stdcxx.m4 to check for C++11 support 66d3713ce7 Merge bitcoin-core/univalue-subtree#29: ci: travis -> cirrus 808d487292 ci: travis -> cirrus c390ac375f Merge bitcoin-core/univalue-subtree#19: Split sources for easier buildsystem integration 4a5b0a1c65 build: Move source entries out to sources.mk 6c7d94b33c build: cleanup wonky gen usage a222637c6d Merge bitcoin-core#23: Merge changes from jgarzik/univalue@1ae6a23 f77d0f718d Merge commit '1ae6a231a0169938eb3972c1d48dd17cba5947e1' into HEAD 1ae6a231a0 Merge pull request bitcoin-core#57 from MarcoFalke/test_fix 92bdd11f0b univalue_write: remove unneeded sstream.h include ffb621c130 Merge pull request bitcoin-core#56 from drodil/remove_sstream_header f33acf9fe8 Merge commit '7890db9~' into HEAD 66e0adec4d Remove unnecessary sstream header from univalue.h 88967f6586 Version 1.0.4 1dc113dbef Merge pull request bitcoin-core#50 from luke-jr/pushKV_bool 72392fb227 [tests] test pushKV for boolean values c23132bcf4 Pushing boolean value to univalue correctly 81faab26a1 Merge pull request bitcoin-core#48 from fwolfst/47-UPDATE_MIT_LINK_TO_HTTPS b17634ef24 Update URLs to MIT license. 88ab64f6b5 Merge pull request bitcoin-core#46 from jasonbcox/master 35ed96da31 Merge pull request bitcoin-core#44 from MarcoFalke/Mf1709-univalue-cherrypick-explicit 420c226290 Merge pull request bitcoin-core#45 from MarcoFalke/Mf1710-univalue-revert-test git-subtree-dir: src/univalue git-subtree-split: a44caf65fe55b9dd8ddb08f04c0f70409efd53b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this, BlockCounter is continuously changing width
unnecessarily. With a fixed width BlockCounter, visual output doesn't
change more than strictly necessary. At current window min size, this
width fits up to 9 digits, which is enough to fit all of main, test
and signature networks.
You can spot the difference these changes add by creating two dummy
data directories and bootstrapping one with this change and
bootstrapping the other one without this change.