Fee selection by johnny9 · Pull Request #546 · bitcoin-core/gui-qml

johnny9 · 2026-04-02T04:28:36Z

Wires up fee selection in the Send page. Overrides are in place for Regtest where CoinControl fee estimations aren't supported.

johnny9 · 2026-04-03T16:23:51Z

Related to #520

MarnixCroes

build fails 5c7cd51

In file included from /usr/include/x86_64-linux-gnu/qt6/QtTest/qtesteventloop.h:8,
                 from /usr/include/x86_64-linux-gnu/qt6/QtTest/qsignalspy.h:11,
                 from /usr/include/x86_64-linux-gnu/qt6/QtTest/QtTest:10,
                 from /home/marnix/projects/gui-qml/test/test_walletqmlmodel.cpp:5:
/home/marnix/projects/gui-qml/test/test_walletqmlmodel.cpp: In lambda function:
/home/marnix/projects/gui-qml/test/test_walletqmlmodel.cpp:409:9: error: return-statement with no value, in function returning ‘util::Result<std::shared_ptr<const CTransaction> >’ [-fpermissive]
  409 |         QCOMPARE(recipients.size(), 1U);
      |         ^~~~~~~~
gmake[2]: *** [test/CMakeFiles/bitcoinqml_unit_tests.dir/build.make:216: test/CMakeFiles/bitcoinqml_unit_tests.dir/test_walletqmlmodel.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:2075: test/CMakeFiles/bitcoinqml_unit_tests.dir/all] Error 2
gmake: *** [Makefile:146: all] Error 2

johnny9 · 2026-04-06T18:23:22Z

fix the compile issue in the unittest

MarnixCroes

a4de80b

some comments from first test (some maybe for follow up):

Fee amount is not displayed in sats in case this is active
The Fee Rate entry is not limited when no decimal is used (i.e. it accepts an unlimited amount of characters as long as no comma is used)
When entering full balance, and not Include fee in amount the Review button doesn't work. Which makes sense, but there is no clear user feedback on why.

pseudoramdom · 2026-04-22T18:50:26Z

a4de80b

Works well.
Would it be good to include fee rate in each of the option - high, default, low? (doesn't have to be in this PR, we can track this separately)

johnny9 · 2026-04-22T19:29:13Z

a4de80b

Works well. Would it be good to include fee rate in each of the option - high, default, low? (doesn't have to be in this PR, we can track this separately)

The fees are based on number of blocks. I think the fee rate might clutter up the information in a dropdown a bit too much but there might be an argument for the fee rate being more important than the fee itself but that migth just be for people that know bitcoin too well.

pseudoramdom · 2026-04-23T21:44:31Z

+    quint64 m_fee_estimate_request_id{0};
+    int m_fee_estimate_revision{0};
+    bool m_custom_fee_enabled{false};
+    bool m_fee_estimate_pending{false};


Do you think it'll be better to extract the fee estimation related code to its own model, say feeselectionmodel.
This way both send and RBF flows can use it

Yes I think that makes sense. Probably some association per transaction with the current_transaction being the one in the send dialog and maybe another for a chosen RBF transaction? I'm not totally sure where it would land but just at a glance it looks like it might be a needed refactor.

# Conflicts: # qml/models/walletqmlmodel.cpp # qml/pages/wallet/DesktopWallets.qml # qml/pages/wallet/Send.qml # test/CMakeLists.txt # test/qml/qml_tests_main.cpp # test/test_unit_tests_main.cpp

MarnixCroes

ACK f3ca7a0

minor issues can be in follow-up
For example, below dust threshold handling

3268d3e qml: Dim conflicted transactions in activity list (pseudoramdom) 2cf482b test: Add functional tests for RBF flow (pseudoramdom) 5999e80 test: Add bump transaction model unit tests & qml tests (pseudoramdom) f4ff2b8 qml: Implement Replace-by-fee (pseudoramdom) Pull request description: Bring support to "Speed up" unconfirmed transactions by bumping fees (#521) - Add `BumpTransactionModel` to manage the fee bump flow - Add `SpeedUpOverlay` popup to review and confirm the higher-fee replacement transaction - Add a reusable` InfoBanner` component for contextual actions/status - Show a speed up banner in transaction details for bumpable transactions - Show a replacement-status banner in transaction details when a transaction has been replaced #### Review note - ~~This PR is stacked on top of #546 (a4de80b)~~ Now merged and this PR is rebased ### Screenshots <img width="1181" height="906" alt="Screenshot 2026-04-24 at 2 51 49 PM" src="https://github.com/user-attachments/assets/93f3a27d-a540-4adb-95ff-0ff339ae3e0d" /> <img width="1428" height="1127" alt="Screenshot 2026-04-25 at 1 18 36 PM" src="https://github.com/user-attachments/assets/d91dd115-4f94-473a-8019-21073555bab3" /> <img width="1428" height="1127" alt="Screenshot 2026-04-25 at 1 19 16 PM" src="https://github.com/user-attachments/assets/73e40893-4f9c-493c-bf6e-6eefe3692f6a" /> <img width="1428" height="1127" alt="Screenshot 2026-04-25 at 1 19 32 PM" src="https://github.com/user-attachments/assets/189a4163-5565-452a-ba5d-ae9c17a71868" /> ACKs for top commit: johnny9: ACK 3268d3e Tree-SHA512: 2d6e887815484d10883adfa84b0f0abcdfc953bf836c683e3c87a186a36a5de03524bf324ed4bd36fccb2e9b747f228a7f6c3eed1bb2c3192e3f1ac8bed2df40

johnny9 force-pushed the standard-fee-selection branch 2 times, most recently from 88739f0 to 7824720 Compare April 2, 2026 13:59

johnny9 changed the title ~~Standard fee selection~~ Fee selection Apr 2, 2026

MarnixCroes reviewed Apr 6, 2026

View reviewed changes

johnny9 force-pushed the standard-fee-selection branch from 5c7cd51 to a4de80b Compare April 6, 2026 17:40

MarnixCroes reviewed Apr 8, 2026

View reviewed changes

pseudoramdom reviewed Apr 23, 2026

View reviewed changes

pseudoramdom mentioned this pull request Apr 25, 2026

Implement Replace-By-Fee speed-up support in the wallet #554

Merged

pseudoramdom mentioned this pull request Apr 29, 2026

Implement Addresses list and Sign/Verify in Wallet Settings #561

Open

hebasto added the Needs rebase label May 1, 2026

johnny9 and others added 13 commits May 2, 2026 23:38

qml: add standard fee selection estimates

f227357

wallet: add fallback fee preview estimates

ea6797c

qml: stabilize fee selection popup layout

105782b

qml: simplify fee selection popup sizing

d6de483

wallet: use static regtest fees for previews

40cc7ad

test: avoid double-linking qml unit sources

64f413d

test: check send fee preview parity

300ff56

test: exercise fee preset dropdown

e747bd0

qml: add custom fee rate mode

8c5b263

qml: remove font.features, requires qt6.6+

76270f2

qml: add include-fee-in-amount send toggle

9a1147e

test: add qml coverage for include-fee send flow

6f82cd1

test: add wallet model unit tests for include-fee flow

e5fab68

johnny9 force-pushed the standard-fee-selection branch from a4de80b to e5fab68 Compare May 3, 2026 03:39

MarnixCroes reviewed May 4, 2026

View reviewed changes

Comment thread qml/pages/wallet/Send.qml Outdated

qml: improve send fee feedback

f3ca7a0

MarnixCroes approved these changes May 7, 2026

View reviewed changes

hebasto merged commit 98954ad into bitcoin-core:qt6 May 8, 2026
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fee selection#546

Fee selection#546
hebasto merged 14 commits into
bitcoin-core:qt6from
johnny9:standard-fee-selection

johnny9 commented Apr 2, 2026 •

edited

Loading

Uh oh!

johnny9 commented Apr 3, 2026

Uh oh!

MarnixCroes left a comment

Uh oh!

johnny9 commented Apr 6, 2026

Uh oh!

MarnixCroes left a comment

Uh oh!

pseudoramdom commented Apr 22, 2026

Uh oh!

johnny9 commented Apr 22, 2026

Uh oh!

pseudoramdom Apr 23, 2026 •

edited

Loading

Uh oh!

johnny9 Apr 24, 2026 •

edited

Loading

Uh oh!

Uh oh!

MarnixCroes left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

johnny9 commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

johnny9 commented Apr 3, 2026

Uh oh!

MarnixCroes left a comment

Choose a reason for hiding this comment

Uh oh!

johnny9 commented Apr 6, 2026

Uh oh!

MarnixCroes left a comment

Choose a reason for hiding this comment

Uh oh!

pseudoramdom commented Apr 22, 2026

Uh oh!

johnny9 commented Apr 22, 2026

Uh oh!

pseudoramdom Apr 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

johnny9 Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MarnixCroes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

johnny9 commented Apr 2, 2026 •

edited

Loading

pseudoramdom Apr 23, 2026 •

edited

Loading

johnny9 Apr 24, 2026 •

edited

Loading