Wallet close, settings, and mempool information#551
Conversation
johnny9
changed the title
johnny9
force-pushed
the
wallet-settings
branch
from
0e7389d to
2604815
Compare
johnny9
force-pushed
the
wallet-settings
branch
from
2604815 to
746825c
Compare
johnny9
force-pushed
the
wallet-settings
branch
2 times, most recently
from
924da78 to
d208480
Compare
johnny9
changed the title
johnny9
changed the title
|
We have a UX to resolve here - You can select wallet A, go to change password, select wallet B and update the password. I don't know for which wallet it applied the password to. wallet-settings.mp4 |
selecting a different wallet should pop the password page from the stack. will add this. |
|
ACK 008bcb7 This is good to merge. There are some follow-ups to do that have been opened as independent issues. |
MarnixCroes
left a comment
MarnixCroes
left a comment
There was a problem hiding this comment.
tested ACK 008bcb7
There are several (minor) issues that can be fixed in follow up.
To name a few:
- The entering of decimals at max mempool size: enter 5,5 -> it changes automatically to 55. Or enter 55,55 it changes to 5,555
- Mempool Information being displayed when running blocksonly
- That there is currently no verification of the wallet name can lead to dislay inaccuracies when renaming a wallet, the names don't update/match:
- When changing the password ,the old password entry at the top should be the one that is automatically selected.
I can't reproduce this or am not fully understanding. The input should not allow decimals values as mempool memory is an integer
|
yes it shouldn't, but it is possible to enter decimals (which works buggy). |
5 participants
Closes #509
Closes #515
Closes #698