ci: Disable binaries for Android task explicitly#58
Closed
hebasto wants to merge 1 commit into
Closed
Conversation
Member
Author
|
Is it reasonable to suggest this PR in the main repo? |
|
What is the reason that |
hebasto
force-pushed
the
211011-android
branch
from
8b8b998 to
9bcf17b
Compare
Member
Author
fwd: @icota This PR just preserves behavior introduced in #17227:
|
Member
Author
|
FWIW, |
maflcko
pushed a commit
to bitcoin-core/gui
that referenced
this pull request
Oct 15, 2021
…id task explicitly 67bb6b5 ci, refactor: Disable binaries for Android task explicitly (Hennadii Stepanov) Pull request description: This PR defines a set of binaries that are compiled in the Android APK task explicitly via `configure` options, that allows to avoid relying on the `test_bitcoin_qt` target from the `src/qt/Makefile`. It is ported from bitcoin-core/gui-qml#58. No behavior change. ACKs for top commit: MarcoFalke: cr ACK 67bb6b5 Tree-SHA512: 9aee1083489a69a40e6779291aba423816f59a1fe6a2156be4edafd0c1c5dd14b99215ca4ff0ec32562e0f43f6ed38e4f8ee562020649be589d258156cea86ab
Merged
hebasto
added a commit
that referenced
this pull request
Oct 19, 2021
Pull request description: Sync with the main repo up to bitcoin-core/gui@ef59692. This sync includes: - bitcoin/bitcoin#23242 ported from #49 - bitcoin/bitcoin#23286 ported from #58 Parent commits: ``` $ git rev-parse 8967f19^@ 8cfb3cb ef59692 ``` ACKs for top commit: jarolrod: ACK 8967f19 Tree-SHA512: c387e638862afe5fd4711d9c1aad36165d04f328612c9b74b35a50b477933e6c6b8cf0674caf3b02e24a22d8598aee7e880baf4c3879c629f71a92af31714548
Member
Author
|
Closing as this is already merged in the main repo and synced with this one. |
knst
pushed a commit
to knst/dash
that referenced
this pull request
Dec 13, 2025
…explicitly 67bb6b5 ci, refactor: Disable binaries for Android task explicitly (Hennadii Stepanov) Pull request description: This PR defines a set of binaries that are compiled in the Android APK task explicitly via `configure` options, that allows to avoid relying on the `test_bitcoin_qt` target from the `src/qt/Makefile`. It is ported from bitcoin-core/gui-qml#58. No behavior change. ACKs for top commit: MarcoFalke: cr ACK 67bb6b5 Tree-SHA512: 9aee1083489a69a40e6779291aba423816f59a1fe6a2156be4edafd0c1c5dd14b99215ca4ff0ec32562e0f43f6ed38e4f8ee562020649be589d258156cea86ab
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this repo GUI test are disabled implicitly as they make no sense for now.
Therefore, the
test_bitcoin_qttarget in thesrc/qt/Makefileis unavailable, that breaks CI Android task.This PR fix this issue by explicitly defining a set of binaries via
configureoptions, that allows to avoid relying on thetest_bitcoin_qttarget from thesrc/qt/Makefile.