Add ProgressIndicator control#69
Conversation
|
Looks good. Any chance that the progress change is animated? So it would smoothly move from one position to the other, with some easing applied maybe? |
|
Yes, something like: Behavior on progress {
SmoothedAnimation {
velocity: 2
}
} |
9ca78aa to
2d92f70
Compare
|
@GBKS added animation. |
|
I am not able to build this one. Getting a series of |
|
Let me rebase this branch @GBKS |
These messages must be completely harmless. |
|
Thanks for looking into this. Here's more of the error message. Does not seem harmless, but I might not be interpreting this correctly. |
2d92f70 to
83c21f6
Compare
|
Rebased. |
What are your |
| contentItem: Rectangle { | ||
| implicitHeight: 6 | ||
| radius: Math.floor(height / 2) | ||
| color: "#404040" |
There was a problem hiding this comment.
We need to move these constants somewhere, something to follow up.
@hebasto yes I think it's fine. What would be the alternative? Drop the commit before merging? Or we should have a separate branch with these demos? |
|
ACK 7dc95a0. A small change would be to speed up the transition a little by setting velocity to 1.5. Overall I'd prefer a consistent animation duration (200ms or so) for this component with a |
83c21f6 to
1bf3d5d
Compare
|
@GBKS changed animation as suggested. |
|
ACK 1bf3d5d Okay sweet, wasn't sure :) |
Pull request description: Sync with the main repo up to bitcoin/bitcoin@c9d7d0a To reproduce: 1) There are merge conflicts. To remedy this, the following commits from the following PR's must be reverted. They have been reverted from newest to oldest as listed: ``` - PR #82 (Nov 12) - 83f1893 - 0f5d210 - PR #79 (Nov 5) - 011fcff - PR #69 (Nov 4) - 1bf3d5d - PR #77 (Nov 3) - 7dc95a0 - 48fb724 - PR #67 (Nov 3) - 61668e9 - 37cfe4e - 5b00612 - PR #65 (Oct 30) - 500a6d2 - PR #74 (Oct 29) - 319db69 - PR #72 (Oct 27) - 749470f - PR #55 (Oct 10) - a13a868 - PR #45 (Oct 3) - 5ce77ad - PR #44 (Oct 3) - 6521cb8 - PR #30 (Aug 30) - 3a0f948 - f17a32a - PR #19 (Aug 19) - 8793ae7 - 3ddb9b3 - e61d42d ``` 2) Fetch the upstream commit ``` git fetch https://github.com/bitcoin/bitcoin git merge c9d7d0a ``` 3) Cherry-pick back the reverted commits from oldest to newest. Note that I have left out 48fb724 and 3ddb9b3 from cherry-picking back in as it is unnecessary and leads to a cleaner commit history. ## GUIX HASHES ``` $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum 6a9def1ba270b4e987c44194bf2704899da603fb25860063fc5ff22ee3b2168b guix-build-ef99bc925033/output/aarch64-linux-gnu/SHA256SUMS.part a5750927e2d5a9086ae70b0279e6d06a48602b1b7b535fe2d1f743d0d320c1b6 guix-build-ef99bc925033/output/aarch64-linux-gnu/bitcoin-ef99bc925033-aarch64-linux-gnu-debug.tar.gz ec1a7e9750df2d00dbb420842ef17813e6f825d06e2122be031c6daf977a9714 guix-build-ef99bc925033/output/aarch64-linux-gnu/bitcoin-ef99bc925033-aarch64-linux-gnu.tar.gz 74aa6e3330956e0d4445c2989056fa807e3dba9a35ec2b38b84c48c0f9bd3efb guix-build-ef99bc925033/output/arm-linux-gnueabihf/SHA256SUMS.part 1c1db52f0bcf91e8c27b150e4c9de3cd235d565e3cdb499dfec8433b4da2119a guix-build-ef99bc925033/output/arm-linux-gnueabihf/bitcoin-ef99bc925033-arm-linux-gnueabihf-debug.tar.gz 9bb58c56527c28b1730dadbf9b169527e056161e30a7cf758b53fdb565f98cdb guix-build-ef99bc925033/output/arm-linux-gnueabihf/bitcoin-ef99bc925033-arm-linux-gnueabihf.tar.gz 325a29527468d7a5686dbcd31602cbae01a41f6cd324680df311815d976f9ca2 guix-build-ef99bc925033/output/dist-archive/bitcoin-ef99bc925033.tar.gz 6e2adbd2a9298f335332b1661e813c9a208a76ad45a37244791756d3296b278d guix-build-ef99bc925033/output/powerpc64-linux-gnu/SHA256SUMS.part e1402abb77216fe1325625404ca8c909b8229f96f58154828c04bb7f699eb9e9 guix-build-ef99bc925033/output/powerpc64-linux-gnu/bitcoin-ef99bc925033-powerpc64-linux-gnu-debug.tar.gz 080ef0d1b1361fbb2354e24d100a49f63ed914afccc69792edd4674ba7d02bb0 guix-build-ef99bc925033/output/powerpc64-linux-gnu/bitcoin-ef99bc925033-powerpc64-linux-gnu.tar.gz e6fb710af41df7be3ae6029ef1114707e0516d551beae0a9928c9de84a025563 guix-build-ef99bc925033/output/powerpc64le-linux-gnu/SHA256SUMS.part 3bb370f79e6fb55ff50ea8db3b49ed7303fce2b9e49af6d0722821b049bfcee4 guix-build-ef99bc925033/output/powerpc64le-linux-gnu/bitcoin-ef99bc925033-powerpc64le-linux-gnu-debug.tar.gz 1ed30ff64eacab08f724e521266784ae21c6ff879cbde7baad21a4b6ceb8ef82 guix-build-ef99bc925033/output/powerpc64le-linux-gnu/bitcoin-ef99bc925033-powerpc64le-linux-gnu.tar.gz dadebd336d5a359105bc4f757f60eba7651ed068a0a8d196ca7a18fa22e692c7 guix-build-ef99bc925033/output/riscv64-linux-gnu/SHA256SUMS.part 208082743c43c37cb6907fe60ddea1909271204188763ee7b214673558f3c18e guix-build-ef99bc925033/output/riscv64-linux-gnu/bitcoin-ef99bc925033-riscv64-linux-gnu-debug.tar.gz a28abc53c3a6cf7ddbd7177e3aae5a4636301c2fb18a0a361cb05d98ef23ea68 guix-build-ef99bc925033/output/riscv64-linux-gnu/bitcoin-ef99bc925033-riscv64-linux-gnu.tar.gz 6f3c8b2fc3fa4638d8adf08f53dce07a9d96a2ef01db1df74ef53799f804ddb2 guix-build-ef99bc925033/output/x86_64-apple-darwin19/SHA256SUMS.part 46160e6460bd1dfd8943f48199daacf58f8e8249edc3757ab681978d72490db9 guix-build-ef99bc925033/output/x86_64-apple-darwin19/bitcoin-ef99bc925033-osx-unsigned.dmg 75f45e27858931ee91201962d1ffa8cf7998da3c962c672403ac8f8888bda7f2 guix-build-ef99bc925033/output/x86_64-apple-darwin19/bitcoin-ef99bc925033-osx-unsigned.tar.gz ee466fca21a6353d2aa6e85be5ac14192ce71430f87c54e8c406398fdeedd73f guix-build-ef99bc925033/output/x86_64-apple-darwin19/bitcoin-ef99bc925033-osx64.tar.gz 44de818d70a295fcd8488142b76a893cd94126ee3aa69d0bfc02096231cfac8c guix-build-ef99bc925033/output/x86_64-linux-gnu/SHA256SUMS.part bb2bc967836cf11bf0412ecc64c1cfbd4076199ac1c1a828919a11802bbd9a4c guix-build-ef99bc925033/output/x86_64-linux-gnu/bitcoin-ef99bc925033-x86_64-linux-gnu-debug.tar.gz 52942d2ba01535b645c6d0460f074a6d683896082fe81b2f31addfc425a631a6 guix-build-ef99bc925033/output/x86_64-linux-gnu/bitcoin-ef99bc925033-x86_64-linux-gnu.tar.gz e437ff82adb1ac30ca9a27bd1732d14f9b17bfa2c9f017aeccadd19685daaf95 guix-build-ef99bc925033/output/x86_64-w64-mingw32/SHA256SUMS.part c4d2ed7580949cc6d4207b57429651a46cc023381b81408adfe4337f360c2be6 guix-build-ef99bc925033/output/x86_64-w64-mingw32/bitcoin-ef99bc925033-win-unsigned.tar.gz e5116106e634d0e1d6a7f509c645de81d19bd7b91243d94a6f90d893ca141016 guix-build-ef99bc925033/output/x86_64-w64-mingw32/bitcoin-ef99bc925033-win64-debug.zip 005710c9e3032dfdc6117a77c38f85a2a5fa723b32772bc33c907298fe91ebfa guix-build-ef99bc925033/output/x86_64-w64-mingw32/bitcoin-ef99bc925033-win64-setup-unsigned.exe c85bb2671820715a97273cc57b81de73f50f95fd8c8909020b08a6be02eb4797 guix-build-ef99bc925033/output/x86_64-w64-mingw32/bitcoin-ef99bc925033-win64.zip ``` [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/87) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/87) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/87) ACKs for top commit: hebasto: ACK ef99bc9 Tree-SHA512: abefdfb363d5ec51c0e4eb079b14e8befd1e921fc19beea210f34f70e80de84c33e4e2e68145eff6cb7e516e73ca2efb0f07fdeafaf440488950170be03ee3a1
Github-Pull: bitcoin-core#69 Rebased-From: 455b2f8
Github-Pull: bitcoin-core#69 Rebased-From: 1bf3d5d
Github-Pull: bitcoin-core#69 Rebased-From: 455b2f8
Github-Pull: bitcoin-core#69 Rebased-From: 1bf3d5d
Github-Pull: bitcoin-core#69 Rebased-From: 455b2f8
Github-Pull: bitcoin-core#69 Rebased-From: 1bf3d5d
Github-Pull: bitcoin-core#69 Rebased-From: 455b2f8
Github-Pull: bitcoin-core#69 Rebased-From: 1bf3d5d
Github-Pull: bitcoin-core#69 Rebased-From: 455b2f8
Github-Pull: bitcoin-core#69 Rebased-From: 1bf3d5d
Github-Pull: bitcoin-core#69 Rebased-From: 455b2f8
Github-Pull: bitcoin-core#69 Rebased-From: 1bf3d5d
Github-Pull: bitcoin-core#69 Rebased-From: 455b2f8
Github-Pull: bitcoin-core#69 Rebased-From: 1bf3d5d
1ae2e09 qml: Demo ProgressIndicator control (João Barbosa) 91e8e86 qml: Add ProgressIndicator control (João Barbosa) Pull request description: Add and use the `ProgressIndicator` control. It can be seen as a more light version of the `ProgressBar` control. The example captures mouse clicks to update the progress. [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/Win64%20\[unit%20tests,%20no%20gui%20tests,%20no%20boost::process,%20no%20functional%20tests\]%20\[focal\]/insecure_win_gui.zip?branch=pull/69) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macOS%2010.15%20\[gui,%20no%20tests\]%20\[focal\]/insecure_mac_gui.zip?branch=pull/69) ACKs for top commit: GBKS: ACK 1ae2e09. Thanks for the animation tweaks. Bosch-0: ACK bitcoin-core/gui-qml@1ae2e09 Tree-SHA512: 9e544e91edbaab81cc6d4700023331e1e9b154945b2837054173f4114275711fdb10a62822e799ad7c49982de592ae80013f790b606417e5704487ca61b8cec8
Pull request description: Sync with the main repo up to bitcoin/bitcoin@c9d7d0a To reproduce: 1) There are merge conflicts. To remedy this, the following commits from the following PR's must be reverted. They have been reverted from newest to oldest as listed: ``` - PR bitcoin-core#82 (Nov 12) - 80ded50 - 0f5d210 - PR bitcoin-core#79 (Nov 5) - 8d5ea7c - PR bitcoin-core#69 (Nov 4) - 1ae2e09 - PR bitcoin-core#77 (Nov 3) - 871de3f - fdc7212 - PR bitcoin-core#67 (Nov 3) - 22b2f0a - c948bc0 - d72de3a - PR bitcoin-core#65 (Oct 30) - c386fbf - PR bitcoin-core#74 (Oct 29) - 319db69 - PR bitcoin-core#72 (Oct 27) - a7028ee - PR bitcoin-core#55 (Oct 10) - 15ee3f4 - PR bitcoin-core#45 (Oct 3) - b431cef - PR bitcoin-core#44 (Oct 3) - 4f1a5d7 - PR bitcoin-core#30 (Aug 30) - 3a0f948 - f17a32a - PR bitcoin-core#19 (Aug 19) - ae72249 - f88cc24 - 2937059 ``` 2) Fetch the upstream commit ``` git fetch https://github.com/bitcoin/bitcoin git merge c9d7d0a ``` 3) Cherry-pick back the reverted commits from oldest to newest. Note that I have left out fdc7212 and f88cc24 from cherry-picking back in as it is unnecessary and leads to a cleaner commit history. ## GUIX HASHES ``` $ find guix-build-$(git rev-parse --short=12 HEAD)/output/ -type f -print0 | env LC_ALL=C sort -z | xargs -r0 sha256sum 6a9def1ba270b4e987c44194bf2704899da603fb25860063fc5ff22ee3b2168b guix-build-f6691736de2a/output/aarch64-linux-gnu/SHA256SUMS.part a5750927e2d5a9086ae70b0279e6d06a48602b1b7b535fe2d1f743d0d320c1b6 guix-build-f6691736de2a/output/aarch64-linux-gnu/bitcoin-f6691736de2a-aarch64-linux-gnu-debug.tar.gz ec1a7e9750df2d00dbb420842ef17813e6f825d06e2122be031c6daf977a9714 guix-build-f6691736de2a/output/aarch64-linux-gnu/bitcoin-f6691736de2a-aarch64-linux-gnu.tar.gz 74aa6e3330956e0d4445c2989056fa807e3dba9a35ec2b38b84c48c0f9bd3efb guix-build-f6691736de2a/output/arm-linux-gnueabihf/SHA256SUMS.part 1c1db52f0bcf91e8c27b150e4c9de3cd235d565e3cdb499dfec8433b4da2119a guix-build-f6691736de2a/output/arm-linux-gnueabihf/bitcoin-f6691736de2a-arm-linux-gnueabihf-debug.tar.gz 9bb58c56527c28b1730dadbf9b169527e056161e30a7cf758b53fdb565f98cdb guix-build-f6691736de2a/output/arm-linux-gnueabihf/bitcoin-f6691736de2a-arm-linux-gnueabihf.tar.gz 325a29527468d7a5686dbcd31602cbae01a41f6cd324680df311815d976f9ca2 guix-build-f6691736de2a/output/dist-archive/bitcoin-f6691736de2a.tar.gz 6e2adbd2a9298f335332b1661e813c9a208a76ad45a37244791756d3296b278d guix-build-f6691736de2a/output/powerpc64-linux-gnu/SHA256SUMS.part e1402abb77216fe1325625404ca8c909b8229f96f58154828c04bb7f699eb9e9 guix-build-f6691736de2a/output/powerpc64-linux-gnu/bitcoin-f6691736de2a-powerpc64-linux-gnu-debug.tar.gz 080ef0d1b1361fbb2354e24d100a49f63ed914afccc69792edd4674ba7d02bb0 guix-build-f6691736de2a/output/powerpc64-linux-gnu/bitcoin-f6691736de2a-powerpc64-linux-gnu.tar.gz e6fb710af41df7be3ae6029ef1114707e0516d551beae0a9928c9de84a025563 guix-build-f6691736de2a/output/powerpc64le-linux-gnu/SHA256SUMS.part 3bb370f79e6fb55ff50ea8db3b49ed7303fce2b9e49af6d0722821b049bfcee4 guix-build-f6691736de2a/output/powerpc64le-linux-gnu/bitcoin-f6691736de2a-powerpc64le-linux-gnu-debug.tar.gz 1ed30ff64eacab08f724e521266784ae21c6ff879cbde7baad21a4b6ceb8ef82 guix-build-f6691736de2a/output/powerpc64le-linux-gnu/bitcoin-f6691736de2a-powerpc64le-linux-gnu.tar.gz dadebd336d5a359105bc4f757f60eba7651ed068a0a8d196ca7a18fa22e692c7 guix-build-f6691736de2a/output/riscv64-linux-gnu/SHA256SUMS.part 208082743c43c37cb6907fe60ddea1909271204188763ee7b214673558f3c18e guix-build-f6691736de2a/output/riscv64-linux-gnu/bitcoin-f6691736de2a-riscv64-linux-gnu-debug.tar.gz a28abc53c3a6cf7ddbd7177e3aae5a4636301c2fb18a0a361cb05d98ef23ea68 guix-build-f6691736de2a/output/riscv64-linux-gnu/bitcoin-f6691736de2a-riscv64-linux-gnu.tar.gz 6f3c8b2fc3fa4638d8adf08f53dce07a9d96a2ef01db1df74ef53799f804ddb2 guix-build-f6691736de2a/output/x86_64-apple-darwin19/SHA256SUMS.part 46160e6460bd1dfd8943f48199daacf58f8e8249edc3757ab681978d72490db9 guix-build-f6691736de2a/output/x86_64-apple-darwin19/bitcoin-f6691736de2a-osx-unsigned.dmg 75f45e27858931ee91201962d1ffa8cf7998da3c962c672403ac8f8888bda7f2 guix-build-f6691736de2a/output/x86_64-apple-darwin19/bitcoin-f6691736de2a-osx-unsigned.tar.gz ee466fca21a6353d2aa6e85be5ac14192ce71430f87c54e8c406398fdeedd73f guix-build-f6691736de2a/output/x86_64-apple-darwin19/bitcoin-f6691736de2a-osx64.tar.gz 44de818d70a295fcd8488142b76a893cd94126ee3aa69d0bfc02096231cfac8c guix-build-f6691736de2a/output/x86_64-linux-gnu/SHA256SUMS.part bb2bc967836cf11bf0412ecc64c1cfbd4076199ac1c1a828919a11802bbd9a4c guix-build-f6691736de2a/output/x86_64-linux-gnu/bitcoin-f6691736de2a-x86_64-linux-gnu-debug.tar.gz 52942d2ba01535b645c6d0460f074a6d683896082fe81b2f31addfc425a631a6 guix-build-f6691736de2a/output/x86_64-linux-gnu/bitcoin-f6691736de2a-x86_64-linux-gnu.tar.gz e437ff82adb1ac30ca9a27bd1732d14f9b17bfa2c9f017aeccadd19685daaf95 guix-build-f6691736de2a/output/x86_64-w64-mingw32/SHA256SUMS.part c4d2ed7580949cc6d4207b57429651a46cc023381b81408adfe4337f360c2be6 guix-build-f6691736de2a/output/x86_64-w64-mingw32/bitcoin-f6691736de2a-win-unsigned.tar.gz e5116106e634d0e1d6a7f509c645de81d19bd7b91243d94a6f90d893ca141016 guix-build-f6691736de2a/output/x86_64-w64-mingw32/bitcoin-f6691736de2a-win64-debug.zip 005710c9e3032dfdc6117a77c38f85a2a5fa723b32772bc33c907298fe91ebfa guix-build-f6691736de2a/output/x86_64-w64-mingw32/bitcoin-f6691736de2a-win64-setup-unsigned.exe c85bb2671820715a97273cc57b81de73f50f95fd8c8909020b08a6be02eb4797 guix-build-f6691736de2a/output/x86_64-w64-mingw32/bitcoin-f6691736de2a-win64.zip ``` [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip?branch=pull/87) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip?branch=pull/87) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip?branch=pull/87) ACKs for top commit: hebasto: ACK f669173 Tree-SHA512: abefdfb363d5ec51c0e4eb079b14e8befd1e921fc19beea210f34f70e80de84c33e4e2e68145eff6cb7e516e73ca2efb0f07fdeafaf440488950170be03ee3a1
1ae2e09b0cedb8e2c52de476058e96f3d755e11e qml: Demo ProgressIndicator control (João Barbosa) 91e8e8618a012e40e2043f883c01a8661d7fe5e0 qml: Add ProgressIndicator control (João Barbosa) Pull request description: Add and use the `ProgressIndicator` control. It can be seen as a more light version of the `ProgressBar` control. The example captures mouse clicks to update the progress. [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/Win64%20\[unit%20tests,%20no%20gui%20tests,%20no%20boost::process,%20no%20functional%20tests\]%20\[focal\]/insecure_win_gui.zip?branch=pull/69) [](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macOS%2010.15%20\[gui,%20no%20tests\]%20\[focal\]/insecure_mac_gui.zip?branch=pull/69) ACKs for top commit: GBKS: ACK 1ae2e09b0cedb8e2c52de476058e96f3d755e11e. Thanks for the animation tweaks. Bosch-0: ACK bitcoin-core/gui-qml@1ae2e09 Tree-SHA512: 9e544e91edbaab81cc6d4700023331e1e9b154945b2837054173f4114275711fdb10a62822e799ad7c49982de592ae80013f790b606417e5704487ca61b8cec8

Add and use the
ProgressIndicatorcontrol. It can be seen as a more light version of theProgressBarcontrol.The example captures mouse clicks to update the progress.