qml: Introduce adaptive sidebar/tab-bar shell driven by size class#690
qml: Introduce adaptive sidebar/tab-bar shell driven by size class#690pseudoramdom wants to merge 2 commits into
Conversation
|
Work towards #689 |
jarolrod
left a comment
There was a problem hiding this comment.
I realize this is a bit away and experimental, but noting a few issues - that would need both design and code work
- No (apparent) ability to create a new wallet when in the collapsed mode
- Node collapsed view can't go into the peers or network traffic page
- no way to switch wallets in collapsed view
- If on tab view on wallet selected, and go to collapsed view, the bottom bar wallet option isn't selected
- if on peers or network traffic page in tab view and scale to collapse down, node isn't selected
All valid issues :)
My original intention was to just include the shell, but one thing led to another and I ended up adding the wallet container. But I got as far as only implementing that in the sidebar layout and left it incomplete for the compact view. (PR size would also grow) Since the changes are additive and I plan on continuing to work on this behind the build flag as more features land. (And nice to meet you here @jarolrod) |

Summary
Introduces an adaptive navigation shell - a single declarative tree of tabs that renders as a persistent sidebar at regular widths and a bottom tab bar at compact widths, swapping automatically at runtime based on the window size.
Gated behind the
-DENABLE_TABVIEW_SHELL=ONCMake flagRelated to #689
Details
TabView API at a glance
Screenshots
Sidebar
Tabbar