Introduce Icon Policy Documentation#310
Closed
jarolrod wants to merge 1 commit into
Closed
Conversation
Contributor
|
Concept ACK ec57f6e |
Bosch-0
suggested changes
May 3, 2021
Contributor
Author
|
Making draft for now as it seems this will be dependent upon the introduction of BitcoinDesign/Bitcoin-Icons. When a PR is opened introducing these new icons, I'll move this out of draft. |
Co-authored-by: jarolrod <jarolrod@tutanota.com>
Contributor
Author
Bosch-0
approved these changes
May 4, 2021
luke-jr
reviewed
Jun 12, 2021
| Optimized PNGs are to be included under the `src/qt/res/icons` directory. | ||
|
|
||
| ## Attribution | ||
| Icon additions must include appropriate attribution to the author, license information, and any comments relevant to the icon documented under the |
Member
There was a problem hiding this comment.
Maybe (re?)state licensing expectations here?
Member
|
What is the current status of this PR? |
Contributor
Author
|
moved to bitcoin-core/gui-qml#70 |
hebasto
added a commit
to bitcoin-core/gui-qml
that referenced
this pull request
Nov 2, 2021
7335bdd doc: introduce icon policy documentation (bosch) Pull request description: Moved from bitcoin-core/gui#310 Picking up bitcoin-core/gui#178 This introduces documented policies for how icons should be prepared, optimized, styled, contributed, and attributed within Bitcoin Core. Having guidelines for iconography helps with making applications more consistent and efficient. [document render](https://github.com/bitcoin-core/gui-qml/blob/23ad199b43e9068d0571eba5965752b03842a7f4/src/qml/doc/icon-policy.md) ACKs for top commit: hebasto: re-ACK 7335bdd Tree-SHA512: aebdfcfea83d23584ccbcf7bdb706bcddfd63dbdb53018ec8220cab87cc92720fd41cb532325e258fff6bcc53b5cebbe498fba2ad95ebebb5da4f868f92607d3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picking up #178
This introduces documented policies for how icons should be prepared, optimized, styled, contributed, and attributed within Bitcoin Core. Having guidelines for iconography helps with making applications more consistent and efficient.
Changes from 35f302d:
optimize-png.pyscript (Added icon policy documentation #178 (comment))