Allow prompt icon to be colorized

[jarolrod]

Opening the console on macOS, while in dark mode, the console prompt icon will not be colorized white like other icons. This applies the platformStyle to the icon so that It can be colorized white.

While here, refactor the promptIcon widget from a QPushButton to QLabel; which is more appropriate, per Qt Docs:

QLabel is used for displaying text or an image. No user interaction functionality is provided.

Master	PR

[hebasto]

Just stating a fact: this PR and #270 (comment) are competing.

[jarolrod]

@hebasto
This and #270 are independent.

Using a new prompt icon is independent from making sure it's colorized white in dark mode.

[hebasto]

@hebasto
This and #270 are independent.

Using a new prompt icon is independent from making sure it's colorized white in dark mode.

Not a new icon, but text:

If you want to have a symbol to indicate user input vs. console output, why not keep it text-based, like in the example below? It uses the ">" character to indicate user input, to match the icon next to the input field.

[jarolrod]

@hebasto

That's in regards to how we should change the console input vs output icons. Not about the prompt icon.

[hebasto]

@hebasto

That's in regards to how we should change the console input vs output icons. Not about the prompt icon.

You're right. Sorry for noise.

[hebasto]

Approach ACK 2162b3e.

[jarolrod]

updated from 2162b3e -> f5e5511 (pr330.01 -> pr330.02, diff)

Changes:

• rebase on master to solve conflict with set shortcuts for console's resize buttons #281
• address comment

@hebasto in regard to your comment
There is no icon property for a QLabel. To address this, I instead also set the pixmap in the *.ui file. Here, I also set the scaled property so that the pixmap will actually show in a designer tool. Because of this, I change the dimension from 16 x 24 to 14 x 14. Here's why:

If I keep the original dimensions, the pixmap will look warped in the designer tool:

It is ok to set the dimensions of the QLabel to the exact dimensions we set for the pixmap itself. Doing so means the pixmap will look normal in the designer tool:

ui->promptIcon->setPixmap(platformStyle->SingleColorIcon(":/icons/prompticon").pixmap(14, 14));

There is no change in the size of this pixmap(previously icon) comparing master, pr330.01, or pr330.02:

Master	PR330.01	PR330.02 (this)

[jarolrod]

updated from f5e5511 -> be85c7f (pr330.02 -> pr330.03, diff)

Changes:

• Address whitespace linter failure
  • The linter does not like a chunk that only adds whitespace, this chunk came to be after rebasing over master. Previously, the same chunk where I added the whitespace added our promptIcon. To fix this, I now set promptIcon below clearButton instead of below fontSmallerButton

[hebasto]

Opening the console on macOS, while in dark mode, the console prompt icon will not be colorized white like other icons. This applies the platformStyle to the icon so that It can be colorized white.

While here, refactor the promptIcon widget from a QPushButton to QLabel; which is more appropriate, per Qt Docs:

QLabel is used for displaying text or an image. No user interaction functionality is provided.

Master PR

Does this line (from #275)

gui/src/qt/rpcconsole.cpp

Line 853 in 123b401

ui->promptIcon->setIcon(platformStyle->SingleColorIcon(QStringLiteral(":/icons/prompticon")));

change anything?

[jarolrod]

@hebasto
It seems that we've uncovered the first "bug" since the merge of 275. If you start off with dark mode on the current master, which includes 275, the promptIcon is colored black. It will become colorized if you switch to light mode then back to dark mode. Below are screenshots showing this behavior

Start with Dark Mode on Master	Switch to Light then Back to Dark

Another thing to notice is that because this is currently a disabled QPushButton, the promptIcon is colored gray instead of white.

Applying this PR on top of master (which requires changes to do), fixes this "bug", makes the promptIcon class appropriate, and lets it be colorized white.

There's currently a silent merge conflict with #275 and will be pushing changes to fix this.

[jarolrod]

updated from be85c7f -> 82d430d (pr330.03 -> pr330.04)

Changes:

• address silent merge conflict with Support runtime appearance adjustment on macOS #275

[hebasto]

I think the current approach is simpler

What about a minimal change:

--- a/src/qt/rpcconsole.cpp
+++ b/src/qt/rpcconsole.cpp
@@ -525,6 +525,8 @@ RPCConsole::RPCConsole(interfaces::Node& node, const PlatformStyle *_platformSty
     //: Secondary shortcut to decrease the RPC console font size.
     GUIUtil::AddButtonShortcut(ui->fontSmallerButton, tr("Ctrl+_"));
 
+    ui->promptIcon->setIcon(platformStyle->SingleColorIcon(QStringLiteral(":/icons/prompticon")));
+
     // Install event filter for up and down arrow
     ui->lineEdit->installEventFilter(this);
     ui->lineEdit->setMaxLength(16 * 1024 * 1024);

?

[jarolrod]

updated from 82d430d -> 8095c81 (pr330.04 -> pr330.05)

Changed:

• Based on make GUIUtil::ThemedLabel UI form friendly #358 so that we can use GUIUtil::ThemedLabel.

[luke-jr]

Prefer to fix with b942216 or such.

It'd be nice to magically make theming work everywhere, but this approach doesn't seem worth it.

[jarolrod]

Updated from 8095c81 -> 2f23ad2 (pr330.05 -> pr330.06)

Changes:

• Use minimal diff solution to accomplish the goal of this PR, as mentioned here and here

Tested on macOS 11.3, macOS 10.15.7, and macOS 10.14.6. Below are screenshots showing the prompt icon properly re-colorized on the mentioned platforms:

macOS 11.3

Start: Dark Mode	Switch: Light Mode

Start: Light Mode	Switch: Dark Mode

macOS 10.15.7

Start: Dark Mode	Switch: Light Mode

Start: Light Mode	Switch: Dark Mode

macOS 10.14.6

Start: Dark Mode	Switch: Light Mode

Start: Light Mode	Switch: Dark Mode

[hebasto]

ACK 2f23ad2