bugfix: initialize IsHDEnabled correctly.#407
Closed
Saibato wants to merge 1 commit into
Closed
Conversation
Saibato
force-pushed
the
icon_update
branch
2 times, most recently
from
9bd6fb8 to
60b9b95
Compare
…key size the result of the call was initialized with true. But in case of no keys, the iterator would be skipped and not set to false. What had resulted in a wrong return and subsequent false icon display in gui.
maflcko
reviewed
Aug 23, 2021
Comment on lines
1366
to
1375
| // All Active ScriptPubKeyMans must be HD for this to be true | ||
| bool result = true; | ||
| bool result = false; | ||
| for (const auto& spk_man : GetActiveScriptPubKeyMans()) { | ||
| result &= spk_man->IsHDEnabled(); | ||
| if (spk_man->IsHDEnabled()) { | ||
| result = true; | ||
| } else { | ||
| return false; | ||
| } | ||
| } | ||
| return result; |
Contributor
There was a problem hiding this comment.
easier would be:
for ...
if ! enabled: return false;
return true;
Contributor
Author
There was a problem hiding this comment.
not quite, since we need to return false of the init value in case the for loop is never entered. afaics.
Contributor
|
This is the wrong repo. To modify wallet code, you will need to submit to the main repo. |
Contributor
Author
fwics it effects only the gui, but you obviously correct, i will file it too under main, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the result of
IsHDEnabled()was initialized with true.But in case of no keys or a blank hd wallet the iterator would be skipped
and not set to false.
What had resulted in a wrong return and subsequent false hd and watch only icon display
in gui when reloading a wallet after closing.
.. PR has move to main repro bitcoin/bitcoin#22781