refactor: Disable unused special members functions in UnlockContext#711
Merged
Conversation
Contributor
|
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers. ReviewsSee the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update. ConflictsReviewers, this pull request conflicts with the following ones:
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first. |
Member
Author
|
Friendly ping @achow101 @furszy @john-moffett @Sjors :) |
furszy
approved these changes
Feb 15, 2023
Member
|
ACK 9fa43b5 |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Feb 16, 2023
…functions in `UnlockContext` 9fa43b5 refactor: Disable unused special members functions in `UnlockContext` (Hennadii Stepanov) Pull request description: Also `UnlockContext::valid` and `UnlockContext::relock` are `const` now. ACKs for top commit: achow101: ACK 9fa43b5 john-moffett: ACK 9fa43b5 furszy: ACK 9fa43b5 Tree-SHA512: 6d9fa8208676b9bd5d85b73cb2d3136e7f28ef59e68ee34915ec598458868e302a80b9ef1384c0bf7a4c42f936830c3add9662ca0bae73860a55a25cc374b699
jonatack
reviewed
Feb 16, 2023
Member
jonatack
left a comment
jonatack
left a comment
There was a problem hiding this comment.
Post-merge ACK and nice application of the rule of five.
ftrader
pushed a commit
to bitcoin-cash-node/bitcoin-cash-node
that referenced
this pull request
Jun 8, 2023
Summary --- This was discovered when trying to investigate fixes to #497. It builds on top of !1760 to completely remove some of the problematic but unused dead code. It is a backport from: bitcoin-core/gui#711 Original commit message: Also UnlockContext::valid and UnlockContext::relock are const now. Test Plan --- - `ninja all check`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also
UnlockContext::validandUnlockContext::relockareconstnow.