cmake: Fix package configuration file#103
Merged
Merged
Conversation
When loading a package configuration file, `find_package` defines variables to provide information about the call arguments. In particular, `CMAKE_FIND_PACKAGE_NAME` represents the package name. This change uses this variable instead of a hardcoded name.
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 23, 2024
Member
Author
|
FWIW, the recent push to bitcoin/bitcoin#29790 uses this PR implementation. |
fanquake
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Jul 24, 2024
ec0e805 depends: Bump `libmultiprocess` for CMake fixes (Hennadii Stepanov) Pull request description: This PR amends #30490 and bumps the upstream branch, which now includes a required CMake [fix](bitcoin-core/libmultiprocess#103). Addresses #30490 (comment). The CI logs are available in #29790 where the recent [push](https://github.com/hebasto/bitcoin/tree/pr29790-0723.2.mp) uses this PR implementation. ACKs for top commit: ryanofsky: Code review ACK ec0e805 theuni: utACK ec0e805. Tree-SHA512: e300a27bcab80a63a518719e9af8e10a938294fc07289cadbf4a7744627c10b0e9541a36971d08b65152f3f7d0eb434e427274d9c9d9f0bdd216afd914027a0f
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Oct 3, 2024
ec0e805 depends: Bump `libmultiprocess` for CMake fixes (Hennadii Stepanov) Pull request description: This PR amends bitcoin#30490 and bumps the upstream branch, which now includes a required CMake [fix](bitcoin-core/libmultiprocess#103). Addresses bitcoin#30490 (comment). The CI logs are available in bitcoin#29790 where the recent [push](https://github.com/hebasto/bitcoin/tree/pr29790-0723.2.mp) uses this PR implementation. ACKs for top commit: ryanofsky: Code review ACK ec0e805 theuni: utACK ec0e805. Tree-SHA512: e300a27bcab80a63a518719e9af8e10a938294fc07289cadbf4a7744627c10b0e9541a36971d08b65152f3f7d0eb434e427274d9c9d9f0bdd216afd914027a0f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When loading a package configuration file,
find_packagedefines variables to provide information about the call arguments. In particular,CMAKE_FIND_PACKAGE_NAMErepresents the package name.This PR uses this variable instead of a hardcoded name, making the use case suggested in #98 (comment) workable: