Skip to content

example: Add missing thread.join() call so example can exit cleanly#109

Merged
ryanofsky merged 1 commit into
bitcoin-core:masterfrom
ryanofsky:pr/bye
Aug 21, 2024
Merged

example: Add missing thread.join() call so example can exit cleanly#109
ryanofsky merged 1 commit into
bitcoin-core:masterfrom
ryanofsky:pr/bye

Conversation

@ryanofsky
Copy link
Copy Markdown
Collaborator

@ryanofsky ryanofsky commented Aug 21, 2024

Problem was pointed out by TheCharlatan in #107 (comment)

@ryanofsky
example: Add missing thread.join() call so example can exit cleanly
70b2d87 
Problem was pointed out by TheCharlatan <seb.kung@gmail.com> in
bitcoin-core#107 (comment)
sedited
sedited approved these changes Aug 21, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@sedited sedited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 70b2d87

I tried adding thread.join() too before, but forgot to apply my prior patch and it never exited, because it still had a client. Thank you!

@ryanofsky ryanofsky merged commit f67cae8 into bitcoin-core:master Aug 21, 2024
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Sep 9, 2024
@ryanofsky
depends: Update libmultiprocess library for CustomMessage functions a…
357a6bc 
…nd cmake headers target

This update brings in the following changes:

bitcoin-core/libmultiprocess#105 types: Add Custom{Build,Read,Pass}Message hooks
bitcoin-core/libmultiprocess#106 Bugfix: Clean up ThreadContext pointers when Connection is destroyed
bitcoin-core/libmultiprocess#107 example: Remove manual client adding
bitcoin-core/libmultiprocess#108 doc: Add comments for socket descriptor handling when forking
bitcoin-core/libmultiprocess#109 example: Add missing thread.join() call so example can exit cleanly
bitcoin-core/libmultiprocess#110 cmake: add target_capnp_sources headers target
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Sep 10, 2024
@ryanofsky
depends: Update libmultiprocess library for CustomMessage functions a…
210700f 
…nd cmake headers target

This update brings in the following changes:

bitcoin-core/libmultiprocess#105 types: Add Custom{Build,Read,Pass}Message hooks
bitcoin-core/libmultiprocess#106 Bugfix: Clean up ThreadContext pointers when Connection is destroyed
bitcoin-core/libmultiprocess#107 example: Remove manual client adding
bitcoin-core/libmultiprocess#108 doc: Add comments for socket descriptor handling when forking
bitcoin-core/libmultiprocess#109 example: Add missing thread.join() call so example can exit cleanly
bitcoin-core/libmultiprocess#110 cmake: add target_capnp_sources headers target
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Sep 10, 2024
@ryanofsky
depends: Update libmultiprocess library for cmake headers target
587c019 
This update brings in the following changes:

bitcoin-core/libmultiprocess#107 example: Remove manual client adding
bitcoin-core/libmultiprocess#108 doc: Add comments for socket descriptor handling when forking
bitcoin-core/libmultiprocess#109 example: Add missing thread.join() call so example can exit cleanly
bitcoin-core/libmultiprocess#110 cmake: add target_capnp_sources headers target
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Sep 17, 2024
@ryanofsky
depends: Update libmultiprocess library for cmake headers target
3d95462 
This update brings in the following changes:

bitcoin-core/libmultiprocess#107 example: Remove manual client adding
bitcoin-core/libmultiprocess#108 doc: Add comments for socket descriptor handling when forking
bitcoin-core/libmultiprocess#109 example: Add missing thread.join() call so example can exit cleanly
bitcoin-core/libmultiprocess#110 cmake: add target_capnp_sources headers target
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Sep 17, 2024
@ryanofsky
depends: Update libmultiprocess library for cmake headers target
2348596 
This update brings in the following changes:

bitcoin-core/libmultiprocess#107 example: Remove manual client adding
bitcoin-core/libmultiprocess#108 doc: Add comments for socket descriptor handling when forking
bitcoin-core/libmultiprocess#109 example: Add missing thread.join() call so example can exit cleanly
bitcoin-core/libmultiprocess#110 cmake: add target_capnp_sources headers target
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Sep 19, 2024
@ryanofsky
depends: Update libmultiprocess library for cmake headers target
8c2dd04 
This update brings in the following changes:

bitcoin-core/libmultiprocess#107 example: Remove manual client adding
bitcoin-core/libmultiprocess#108 doc: Add comments for socket descriptor handling when forking
bitcoin-core/libmultiprocess#109 example: Add missing thread.join() call so example can exit cleanly
bitcoin-core/libmultiprocess#110 cmake: add target_capnp_sources headers target
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Sep 19, 2024
@ryanofsky
depends: Update libmultiprocess library for cmake headers target
72689b1 
This update brings in the following changes:

bitcoin-core/libmultiprocess#107 example: Remove manual client adding
bitcoin-core/libmultiprocess#108 doc: Add comments for socket descriptor handling when forking
bitcoin-core/libmultiprocess#109 example: Add missing thread.join() call so example can exit cleanly
bitcoin-core/libmultiprocess#110 cmake: add target_capnp_sources headers target
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Sep 24, 2024
@ryanofsky
depends: Update libmultiprocess library for cmake headers target
287eafc 
This update brings in the following changes:

bitcoin-core/libmultiprocess#107 example: Remove manual client adding
bitcoin-core/libmultiprocess#108 doc: Add comments for socket descriptor handling when forking
bitcoin-core/libmultiprocess#109 example: Add missing thread.join() call so example can exit cleanly
bitcoin-core/libmultiprocess#110 cmake: add target_capnp_sources headers target
ryanofsky added a commit to ryanofsky/bitcoin that referenced this pull request Sep 24, 2024
@ryanofsky
depends: Update libmultiprocess library for cmake headers target
070e6a3 
This update brings in the following changes:

bitcoin-core/libmultiprocess#107 example: Remove manual client adding
bitcoin-core/libmultiprocess#108 doc: Add comments for socket descriptor handling when forking
bitcoin-core/libmultiprocess#109 example: Add missing thread.join() call so example can exit cleanly
bitcoin-core/libmultiprocess#110 cmake: add target_capnp_sources headers target
janus pushed a commit to BitgesellOfficial/bitgesell that referenced this pull request Jan 19, 2025
@ryanofsky @janus
depends: Update libmultiprocess library for cmake headers target
2864e76 
This update brings in the following changes:

bitcoin-core/libmultiprocess#107 example: Remove manual client adding
bitcoin-core/libmultiprocess#108 doc: Add comments for socket descriptor handling when forking
bitcoin-core/libmultiprocess#109 example: Add missing thread.join() call so example can exit cleanly
bitcoin-core/libmultiprocess#110 cmake: add target_capnp_sources headers target
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Aug 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sedited sedited sedited approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ryanofsky @sedited