Skip to content

Fix clang compiler warnings #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanofsky merged 3 commits into from
Dec 22, 2021
Merged

Fix clang compiler warnings #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
921e23e
Disable clang suggest-override warnings for proxy clients
ryanofsky Dec 22, 2021
5738b8a
Avoid delete-non-abstract-non-virtual-dtor warnings
ryanofsky Dec 22, 2021
1b638d6
Avoid delete-non-abstract-non-virtual-dtor warnings for mp::ProxyCall…
ryanofsky Dec 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/mp/proxy-types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -644,7 +644,7 @@ void BuildField(TypeList<LocalTypes...>, Context& context, Output&& output, Valu

//! Adapter to convert ProxyCallback object call to function object call.
template <typename Result, typename... Args>
class ProxyCallbackImpl : public ProxyCallback<std::function<Result(Args...)>>
class ProxyCallbackImpl final : public ProxyCallback<std::function<Result(Args...)>>
{
using Fn = std::function<Result(Args...)>;
Fn m_fn;
Expand Down
6 changes: 3 additions & 3 deletions src/mp/gen.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ void Generate(kj::StringPtr src_prefix,
}
}
h << "#include <" << PROXY_DECL << ">\n\n";
h << "#if defined(__GNUC__) && !defined(__clang__)\n";
h << "#if defined(__GNUC__)\n";
h << "#pragma GCC diagnostic push\n";
h << "#pragma GCC diagnostic ignored \"-Wsuggest-override\"\n";
h << "#endif\n";
Expand Down Expand Up @@ -330,7 +330,7 @@ void Generate(kj::StringPtr src_prefix,
const auto& interface = node.asInterface();

std::ostringstream client;
client << "template<>\nstruct ProxyClient<" << message_namespace << "::" << node_name << "> : ";
client << "template<>\nstruct ProxyClient<" << message_namespace << "::" << node_name << "> final : ";
client << "public ProxyClientCustom<" << message_namespace << "::" << node_name << ", "
<< proxied_class_type << ">\n{\n";
client << "public:\n";
Expand Down Expand Up @@ -581,7 +581,7 @@ void Generate(kj::StringPtr src_prefix,
inl << "#endif\n";

h << "} // namespace mp\n";
h << "#if defined(__GNUC__) && !defined(__clang__)\n";
h << "#if defined(__GNUC__)\n";
h << "#pragma GCC diagnostic pop\n";
h << "#endif\n";
h << "#endif\n";
Expand Down