Skip to content

refactor: Do not shadow InvokeContext::connection member#78

Merged
ryanofsky merged 1 commit into
bitcoin-core:masterfrom
hebasto:220916-warnings
Sep 19, 2022
Merged

refactor: Do not shadow InvokeContext::connection member#78
ryanofsky merged 1 commit into
bitcoin-core:masterfrom
hebasto:220916-warnings

Conversation

@hebasto
Copy link
Copy Markdown
Member

@hebasto hebasto commented Sep 16, 2022

Fixes -Wshadow-field warning.

Closes #77.

ryanofsky
ryanofsky approved these changes Sep 19, 2022
View reviewed changes
Copy link
Copy Markdown
Collaborator

@ryanofsky ryanofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review ACK f999694

@ryanofsky ryanofsky merged commit ddd2cee into bitcoin-core:master Sep 19, 2022
@ryanofsky
Copy link
Copy Markdown
Collaborator

ryanofsky commented Sep 19, 2022

Thanks for the fix!

@hebasto hebasto deleted the 220916-warnings branch September 20, 2022 08:18
@hebasto hebasto mentioned this pull request Dec 9, 2022
Merged
fanquake added a commit to bitcoin-core/gui that referenced this pull request Dec 10, 2022
@fanquake
Merge bitcoin/bitcoin#26672: build: Update libmultiprocess library
e1fb738 
1986f12 build: Update `libmultiprocess` library (Hennadii Stepanov)

Pull request description:

  This update in particular includes:
  - bitcoin-core/libmultiprocess#78 which is [required](bitcoin/bitcoin#25972 (comment)) for bitcoin/bitcoin#25972
  - bitcoin-core/libmultiprocess#74
  - bitcoin-core/libmultiprocess#70

ACKs for top commit:
  ryanofsky:
    Code review ACK 1986f12

Tree-SHA512: 2d9fa72df5de7d5be37d77d479702cba36c45e9fa9d9fc27e58aac0437c39e4a1054c0ac53b612cb43e830982e444d98c7d3e651d093ac68344e66f4734227bb
sidhujag pushed a commit to syscoin/syscoin that referenced this pull request Dec 10, 2022
@fanquake
Merge bitcoin#26672: build: Update libmultiprocess library
e603e70 
1986f12 build: Update `libmultiprocess` library (Hennadii Stepanov)

Pull request description:

  This update in particular includes:
  - bitcoin-core/libmultiprocess#78 which is [required](bitcoin#25972 (comment)) for bitcoin#25972
  - bitcoin-core/libmultiprocess#74
  - bitcoin-core/libmultiprocess#70

ACKs for top commit:
  ryanofsky:
    Code review ACK 1986f12

Tree-SHA512: 2d9fa72df5de7d5be37d77d479702cba36c45e9fa9d9fc27e58aac0437c39e4a1054c0ac53b612cb43e830982e444d98c7d3e651d093ac68344e66f4734227bb
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Oct 1, 2024
@fanquake @PastaPastaPasta
Merge bitcoin#26672: build: Update libmultiprocess library
ad0c279 
1986f12 build: Update `libmultiprocess` library (Hennadii Stepanov)

Pull request description:

  This update in particular includes:
  - bitcoin-core/libmultiprocess#78 which is [required](bitcoin#25972 (comment)) for bitcoin#25972
  - bitcoin-core/libmultiprocess#74
  - bitcoin-core/libmultiprocess#70

ACKs for top commit:
  ryanofsky:
    Code review ACK 1986f12

Tree-SHA512: 2d9fa72df5de7d5be37d77d479702cba36c45e9fa9d9fc27e58aac0437c39e4a1054c0ac53b612cb43e830982e444d98c7d3e651d093ac68344e66f4734227bb
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Jun 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ryanofsky ryanofsky ryanofsky approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Warnings (soon-to-be) emitted in the Core multiprocess build

2 participants

@hebasto @ryanofsky