cmake: rename new packages and module introduced in #95 and #96#97
Merged
Conversation
bitcoin-core#96 Rename "LibmultiprocessMacros.cmake" module to "TargetCapnpSources.cmake" to match the name of the target_capnp_sources function it contains. Also install it <prefix>/lib/cmake/Libmultiprocess/TargetCapnpSources.cmake instead of: <prefix>/lib/cmake/LibmultiprocessGen/LibmultiprocessMacros.cmake Rename the "LibmultiprocessGen" package to "LibmultiprocessBin" and rename the "Libmultiprocess" package to "LibmultiprocessLib", so package names are consistent with component names "bin" and "lib", and one package name is not a prefix of the other. Also rename intermediate files to match component names. |----------------+----------------------------------+----------------------------------------------| | | New | Current | |----------------+----------------------------------+----------------------------------------------| | Component name | lib | lib | | Package name | LibmultiprocessLib | Libmultiprocess | | Config file | LibmultiprocessLibConfig.cmake | Libmultiprocess/LibmultiprocessConfig.cmake | | Targets file | Libmultiprocess/LibTargets.cmake | Libmultiprocess/LibmultiprocessTargets.cmake | |----------------+----------------------------------+----------------------------------------------| |----------------+----------------------------------+----------------------------------------------------| | | New | Current | |----------------+----------------------------------+----------------------------------------------------| | Component name | bin | bin | | Package name | LibmultiprocessBin | LibmultiprocessGen | | Config file | LibmultiprocessBinConfig.cmake | LibmultiprocessGen/LibmultiprocessGenConfig.cmake | | Targets file | Libmultiprocess/BinTargets.cmake | LibmultiprocessGen/LibmultiprocessGenTargets.cmake | |----------------+----------------------------------+----------------------------------------------------|
Member
|
After the following commands: I have the following installation A downstream project being provided with In short, paths like |
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Mar 30, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
ryanofsky
added a commit
to ryanofsky/libmultiprocess
that referenced
this pull request
Apr 1, 2024
This change combines previous installed "cmake/LibmultiprocessLibConfig.cmake" and "cmake/LibmultiprocessBinConfig.cmake" files into a single "cmake/Libmultiprocess/LibmultiprocessConfig.cmake" file, so it can be imported with "find_package(Libmultiprocess)". The previous locations which were set in bitcoin-core#97 were not actually compatible with find_package search behavior by default. The change also adds some documentation about using the new package to doc/install.md.
ryanofsky
added a commit
that referenced
this pull request
Apr 1, 2024
dc9b4e6 cmake: Combine installed packages (Ryan Ofsky) 2ed1e9a cmake: CMakeLists.txt cleanup (Ryan Ofsky) Pull request description: This change combines previous installed: - `cmake/LibmultiprocessLibConfig.cmake` - `cmake/LibmultiprocessBinConfig.cmake` files into a single: - `cmake/Libmultiprocess/LibmultiprocessConfig.cmake` file, so it can be imported with `find_package(Libmultiprocess)`. The previous locations which were set in #97 were not compatible with `find_package` search behavior by default. The change also adds some documentation about using the new package to doc/install.md. Top commit has no ACKs. Tree-SHA512: 506a2f73f19de541d36cc192f3553ae583e78644f60e958234b2a29d0c5f053890bbe176f7dbd38bad0598a5fa2426a34e64b0f266bc87a01eaa21cb7ecd1226
Collaborator
Author
|
Thanks for catching this. I accidentally replied to the wrong issue earlier in #95 (comment). I posted an update in #98 which should fix this, but if there's any problem just let me know. |
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Apr 3, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Apr 16, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Apr 29, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
vasild
pushed a commit
to vasild/bitcoin
that referenced
this pull request
Apr 30, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
May 4, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
May 20, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jun 4, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jun 13, 2024
Fix "connection: run async cleanups in LIFO not FIFO order" bitcoin-core/libmultiprocess#101 is needed to prevent CI failure https://cirrus-ci.com/task/4549686449668096 caused by wallet processes deadlocking during shutdown when node process is killed. This also includes other recent changes: bitcoin-core/libmultiprocess#95: cmake: Introduce `LibmultiprocessMacros` module bitcoin-core/libmultiprocess#96: cmake: Introduce packages bitcoin-core/libmultiprocess#97: cmake: rename new packages and module introduced in bitcoin#95 and bitcoin#96 bitcoin-core/libmultiprocess#98: cmake: Combine installed packages bitcoin-core/libmultiprocess#99: proxy-types: Fix missing space in server destroy log print bitcoin-core/libmultiprocess#100: doc: Add various code comments and documentation bitcoin-core/libmultiprocess#102: doc: Document shutdown sequences better
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jun 29, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jun 30, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 3, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 3, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 4, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 11, 2024
depends: Update libmultiprocess library Fix "connection: run async cleanups in LIFO not FIFO order" bitcoin-core/libmultiprocess#101 is needed to prevent CI failure https://cirrus-ci.com/task/4549686449668096 caused by wallet processes deadlocking during shutdown when node process is killed. This also includes other recent changes: bitcoin-core/libmultiprocess#95: cmake: Introduce `LibmultiprocessMacros` module bitcoin-core/libmultiprocess#96: cmake: Introduce packages bitcoin-core/libmultiprocess#97: cmake: rename new packages and module introduced in bitcoin#95 and bitcoin#96 bitcoin-core/libmultiprocess#98: cmake: Combine installed packages bitcoin-core/libmultiprocess#99: proxy-types: Fix missing space in server destroy log print bitcoin-core/libmultiprocess#100: doc: Add various code comments and documentation bitcoin-core/libmultiprocess#102: doc: Document shutdown sequences better
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 12, 2024
Fix "connection: run async cleanups in LIFO not FIFO order" bitcoin-core/libmultiprocess#101 is needed to prevent CI failure https://cirrus-ci.com/task/4549686449668096 caused by wallet processes deadlocking during shutdown when node process is killed. This also includes other recent changes: bitcoin-core/libmultiprocess#95: cmake: Introduce `LibmultiprocessMacros` module bitcoin-core/libmultiprocess#96: cmake: Introduce packages bitcoin-core/libmultiprocess#97: cmake: rename new packages and module introduced in bitcoin#95 and bitcoin#96 bitcoin-core/libmultiprocess#98: cmake: Combine installed packages bitcoin-core/libmultiprocess#99: proxy-types: Fix missing space in server destroy log print bitcoin-core/libmultiprocess#100: doc: Add various code comments and documentation bitcoin-core/libmultiprocess#102: doc: Document shutdown sequences better
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 13, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 15, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 16, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
hebasto
added a commit
to hebasto/bitcoin
that referenced
this pull request
Jul 16, 2024
Not using the latest commit 3f8483b61a5eee3e958328d90f25f29a1a61ae7b due to bitcoin-core/libmultiprocess#97 (comment)
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 16, 2024
Fix "connection: run async cleanups in LIFO not FIFO order" bitcoin-core/libmultiprocess#101 is needed to prevent CI failure https://cirrus-ci.com/task/4549686449668096 caused by wallet processes deadlocking during shutdown when node process is killed. This also includes other recent changes: bitcoin-core/libmultiprocess#95: cmake: Introduce `LibmultiprocessMacros` module bitcoin-core/libmultiprocess#96: cmake: Introduce packages bitcoin-core/libmultiprocess#97: cmake: rename new packages and module introduced in bitcoin#95 and bitcoin#96 bitcoin-core/libmultiprocess#98: cmake: Combine installed packages bitcoin-core/libmultiprocess#99: proxy-types: Fix missing space in server destroy log print bitcoin-core/libmultiprocess#100: doc: Add various code comments and documentation bitcoin-core/libmultiprocess#102: doc: Document shutdown sequences better
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 16, 2024
Fix "connection: run async cleanups in LIFO not FIFO order" bitcoin-core/libmultiprocess#101 is needed to prevent CI failure https://cirrus-ci.com/task/4549686449668096 caused by wallet processes deadlocking during shutdown when node process is killed. This also includes other recent changes: bitcoin-core/libmultiprocess#95: cmake: Introduce `LibmultiprocessMacros` module bitcoin-core/libmultiprocess#96: cmake: Introduce packages bitcoin-core/libmultiprocess#97: cmake: rename new packages and module introduced in bitcoin#95 and bitcoin#96 bitcoin-core/libmultiprocess#98: cmake: Combine installed packages bitcoin-core/libmultiprocess#99: proxy-types: Fix missing space in server destroy log print bitcoin-core/libmultiprocess#100: doc: Add various code comments and documentation bitcoin-core/libmultiprocess#102: doc: Document shutdown sequences better
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 18, 2024
Fix "connection: run async cleanups in LIFO not FIFO order" bitcoin-core/libmultiprocess#101 is needed to prevent CI failure https://cirrus-ci.com/task/4549686449668096 caused by wallet processes deadlocking during shutdown when node process is killed. This also includes other recent changes: bitcoin-core/libmultiprocess#95: cmake: Introduce `LibmultiprocessMacros` module bitcoin-core/libmultiprocess#96: cmake: Introduce packages bitcoin-core/libmultiprocess#97: cmake: rename new packages and module introduced in bitcoin#95 and bitcoin#96 bitcoin-core/libmultiprocess#98: cmake: Combine installed packages bitcoin-core/libmultiprocess#99: proxy-types: Fix missing space in server destroy log print bitcoin-core/libmultiprocess#100: doc: Add various code comments and documentation bitcoin-core/libmultiprocess#102: doc: Document shutdown sequences better
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 18, 2024
Fix "connection: run async cleanups in LIFO not FIFO order" bitcoin-core/libmultiprocess#101 is needed to prevent CI failure https://cirrus-ci.com/task/4549686449668096 caused by wallet processes deadlocking during shutdown when node process is killed. This also includes other recent changes: bitcoin-core/libmultiprocess#95: cmake: Introduce `LibmultiprocessMacros` module bitcoin-core/libmultiprocess#96: cmake: Introduce packages bitcoin-core/libmultiprocess#97: cmake: rename new packages and module introduced in bitcoin#95 and bitcoin#96 bitcoin-core/libmultiprocess#98: cmake: Combine installed packages bitcoin-core/libmultiprocess#99: proxy-types: Fix missing space in server destroy log print bitcoin-core/libmultiprocess#100: doc: Add various code comments and documentation bitcoin-core/libmultiprocess#102: doc: Document shutdown sequences better
Sjors
pushed a commit
to Sjors/bitcoin
that referenced
this pull request
Jul 19, 2024
Fix "connection: run async cleanups in LIFO not FIFO order" bitcoin-core/libmultiprocess#101 is needed to prevent CI failure https://cirrus-ci.com/task/4549686449668096 caused by wallet processes deadlocking during shutdown when node process is killed. This also includes other recent changes: bitcoin-core/libmultiprocess#95: cmake: Introduce `LibmultiprocessMacros` module bitcoin-core/libmultiprocess#96: cmake: Introduce packages bitcoin-core/libmultiprocess#97: cmake: rename new packages and module introduced in #95 and #96 bitcoin-core/libmultiprocess#98: cmake: Combine installed packages bitcoin-core/libmultiprocess#99: proxy-types: Fix missing space in server destroy log print bitcoin-core/libmultiprocess#100: doc: Add various code comments and documentation bitcoin-core/libmultiprocess#102: doc: Document shutdown sequences better
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 24, 2024
Fix "connection: run async cleanups in LIFO not FIFO order" bitcoin-core/libmultiprocess#101 is needed to prevent CI failure https://cirrus-ci.com/task/4549686449668096 caused by wallet processes deadlocking during shutdown when node process is killed. This also includes other recent changes: bitcoin-core/libmultiprocess#95: cmake: Introduce `LibmultiprocessMacros` module bitcoin-core/libmultiprocess#96: cmake: Introduce packages bitcoin-core/libmultiprocess#97: cmake: rename new packages and module introduced in bitcoin#95 and bitcoin#96 bitcoin-core/libmultiprocess#98: cmake: Combine installed packages bitcoin-core/libmultiprocess#99: proxy-types: Fix missing space in server destroy log print bitcoin-core/libmultiprocess#100: doc: Add various code comments and documentation bitcoin-core/libmultiprocess#102: doc: Document shutdown sequences better
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Jul 26, 2024
Fix "connection: run async cleanups in LIFO not FIFO order" bitcoin-core/libmultiprocess#101 is needed to prevent CI failure https://cirrus-ci.com/task/4549686449668096 caused by wallet processes deadlocking during shutdown when node process is killed. This also includes other recent changes: bitcoin-core/libmultiprocess#95: cmake: Introduce `LibmultiprocessMacros` module bitcoin-core/libmultiprocess#96: cmake: Introduce packages bitcoin-core/libmultiprocess#97: cmake: rename new packages and module introduced in bitcoin#95 and bitcoin#96 bitcoin-core/libmultiprocess#98: cmake: Combine installed packages bitcoin-core/libmultiprocess#99: proxy-types: Fix missing space in server destroy log print bitcoin-core/libmultiprocess#100: doc: Add various code comments and documentation bitcoin-core/libmultiprocess#102: doc: Document shutdown sequences better
ryanofsky
added a commit
to ryanofsky/bitcoin
that referenced
this pull request
Sep 26, 2024
Fix "connection: run async cleanups in LIFO not FIFO order" bitcoin-core/libmultiprocess#101 is needed to prevent CI failure https://cirrus-ci.com/task/4549686449668096 caused by wallet processes deadlocking during shutdown when node process is killed. This also includes other recent changes: bitcoin-core/libmultiprocess#95: cmake: Introduce `LibmultiprocessMacros` module bitcoin-core/libmultiprocess#96: cmake: Introduce packages bitcoin-core/libmultiprocess#97: cmake: rename new packages and module introduced in bitcoin#95 and bitcoin#96 bitcoin-core/libmultiprocess#98: cmake: Combine installed packages bitcoin-core/libmultiprocess#99: proxy-types: Fix missing space in server destroy log print bitcoin-core/libmultiprocess#100: doc: Add various code comments and documentation bitcoin-core/libmultiprocess#102: doc: Document shutdown sequences better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename "LibmultiprocessMacros.cmake" module introduced in #95 to "TargetCapnpSources.cmake" to match the name of the
target_capnp_sourcesfunction it contains. Also install it to:instead of:
Rename the "Libmultiprocess" and "LibmultiprocessGen" packages introduced in #96 to "LibmultiprocessLib" and "LibmultiprocessBin", so package names are consistent with component names "lib" and "bin", and one package name is not a prefix of the other. Also rename intermediate files to match component names.