Skip to content

ci: Move to gha#339

Merged
achow101 merged 3 commits intobitcoin-core:mainfrom
maflcko:ci
Apr 9, 2026
Merged

ci: Move to gha#339
achow101 merged 3 commits intobitcoin-core:mainfrom
maflcko:ci

Conversation

@maflcko
Copy link
Copy Markdown
Contributor

@maflcko maflcko commented Apr 8, 2026

Fixes #338

achow101 and others added 3 commits February 11, 2026 12:13
605cb8f snap: Update to 30.2 (Ava Chow)

Pull request description:

Top commit has no ACKs.

Tree-SHA512: 81768c981c4b1d9c5f34b847a06edba03a04ffee7588b8268d3d383744d9a2b551a6bfb5109c7d004f4b15bac5c17d046ce5305ddab9887555723a370a48c95f
@achow101
Copy link
Copy Markdown
Member

achow101 commented Apr 8, 2026

There's a snapcraft build action as well as a publish action that we may want to use instead of just doing snapcraft build in a container. Using the publish action would also let us move away from needing to use launchpad to do releases.

@achow101 achow101 closed this Apr 8, 2026
@achow101 achow101 reopened this Apr 8, 2026
@maflcko
Copy link
Copy Markdown
Contributor Author

maflcko commented Apr 9, 2026

I know there is an issue about that in #299.

My preference would be to keep this a trivial move-only for now.

Changing the build process can be done in a follow-up. Personally, I am not sure if a GHA VM is the right place to conduct a build, given that it is controlled by yet another untrusted third party, and that the VM is filled with tens of GBs of unrelated (possibly backdoored) software.

@maflcko maflcko closed this Apr 9, 2026
@maflcko maflcko reopened this Apr 9, 2026
@maflcko
Copy link
Copy Markdown
Contributor Author

maflcko commented Apr 9, 2026

The CI won't run here, because the yaml does not exist in the main branch, but the CI did run in my repo, if someone wants to take a look.

@achow101
Copy link
Copy Markdown
Member

achow101 commented Apr 9, 2026

Can you base on main instead of 30.x? This has the 30.2 update.

@maflcko
Copy link
Copy Markdown
Contributor Author

maflcko commented Apr 9, 2026

This is already based on main, which is missing the 30.2 update. The 30.2 update is required, because CI would otherwise fail with a hash mismatch. Unrelated: Reminds me that the curl should probably specify --fail, for an early and clearer error.

@achow101
Copy link
Copy Markdown
Member

achow101 commented Apr 9, 2026

ACK fa2a5ef

@achow101 achow101 merged commit d786f62 into bitcoin-core:main Apr 9, 2026
@maflcko maflcko deleted the ci branch April 10, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: [snap] Move to GHA

2 participants